Skip to content

Remove orphaned keys from package.nls.json (#22478) - #26159

Open
Shriraj Jadhav (Shriraj1901) wants to merge 1 commit into
microsoft:mainfrom
Shriraj1901:fix-orphaned-nls-keys
Open

Shriraj Jadhav (Shriraj1901) wants to merge 1 commit into
microsoft:mainfrom
Shriraj1901:fix-orphaned-nls-keys

Conversation

@Shriraj1901

Copy link
Copy Markdown

Description

Removes 8 unused localization keys from package.nls.json that no longer have any corresponding reference in package.json or anywhere in the extension source code (src/).

The orphaned keys break down into two groups:

  • TensorBoard-related (6 keys): TensorBoard support was moved to a separate extension (per the existing deprecation message in the file itself), but these command titles, experiment description, and log directory strings were never cleaned up.
  • Walkthrough (2 keys): The old "Select a Python Interpreter" walkthrough step's title/altText, which was merged into the newer "Select or create a Python environment" step.

How this was verified

Ran a script comparing every %key% reference across package.json against package.nls.json, and separately searched the entire src/**/*.ts for any remaining usage of each orphaned key. All 8 came back with zero references anywhere in the codebase.

Fixes #22478

Removes 8 unused localization keys that no longer have any
corresponding reference in package.json or the extension source:
- 2 TensorBoard command titles (feature moved to separate extension)
- TensorBoard experiment description
- 3 TensorBoard log directory strings
- 2 walkthrough 'Select a Python Interpreter' strings (step was
  merged into the 'createEnvironment' walkthrough step)

Verified via search across src/**/*.ts that none of these keys
are referenced anywhere in the codebase.
@bschnurr

Bill Schnurr (bschnurr) commented Sep 21, 2026

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: The verification sandbox failed during staging, before the discovery command or tests could execute. Read-only inspection found no dedicated test covering removal of orphaned `package.nls.json` keys, and the PR adds no tests. Therefore, runtime verification could not be completed.

Test runs: 1 not run

  • ⚠️ Not run | Dependency and test discovery preflight | printf 'sandbox_profile=%s\n' "${AUTOMATION_SANDBOX_PROFILE:-}"; printf '%s\n' '--- changed files ---'; base=$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD upstream/main 2>/dev/null); printf 'base=%s\n' "$base"; git diff --name-status "$base"..HEAD; printf '%s\n' '--- dependency/tool availability ---'; if [ -d node_modules ]; then echo 'node_modules=present'; else echo 'node_modules=missing'; fi; node --version; if [ -x node_modules/.bin/mocha ]; then node_modules/.bin/mocha --version; else echo 'mocha=missing'; fi; printf '%s\n' '--- relevant scripts/config ---'; node -e "const p=require('./package.json'); for (const [k,v] of Object.entries(p.scripts||{})) if (/test:functional|compile/.test(k)) console.log(k+'='+v)"; sed -n '1,120p' build/.mocha.functional.json
⚠️ Dependency and test discovery preflight diagnostic output
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\bschnurr\\AppData\\Local\\Temp\\automation-job-ready-4gxayiva'

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@Shriraj1901

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match keys in package.nls.json to setting names

2 participants