Test: Mark as Done nudge and session-list onboarding

[benibenj]

Refs: #335360, #335406

• anyOS Megan Rogge (@meganrogge)
• anyOS Dirk Bäumer (@dbaeumer)

Complexity: 3

Authors: Benjamin Christopher Simmonds (@benibenj)

Create Issue

---

After a pull request is merged, the Agents Window suggests marking the session as done. On first use, a spotlight introduces the Mark as Done action in the sessions list. This spotlight normally shows only once per user, not once per session.

Setup

• Use Insiders with these changes and enable chat.agentSessions.archiveNudge.enabled. Keep onboarding.enabled enabled.
• Have the agent create a pull request from a session in the Agents Window, merge the PR on GitHub, then return to the idle, connected session. The nudge should appear once the merged status is detected.
• Use disposable sessions: Mark as Done is a real action and may remove their worktrees.

Test

• Check that the nudge has a purple merge icon and a primary Mark as Done button. Its introductory sentence stays visible; the underlined explanation starts collapsed and can be expanded/collapsed using mouse or keyboard.
• Hide the sessions sidebar, then click Mark as Done in the nudge. The sidebar and correct session should be revealed, with its Mark as Done action visible and spotlighted. The session must not be marked as done while the spotlight is open.
• Click Understood. The spotlight should close and the session should be marked as done. On another session, the nudge should mark it as done immediately without repeating the spotlight, including after a window reload when the developer override below is not set.
• Replay the spotlight using the setting below and try finishing via the highlighted Mark as Done action or Escape. Both should finish the tour and mark the session as done. Also try a session that is pinned or hidden by a filter/collapsed group.
• Check that dismissing the nudge does not mark the session as done, and Configure Automatic Cleanup shows only the two session cleanup settings. Explore keyboard navigation and light/dark themes.

Replaying the spotlight

To test again if you have already seen the spotlight, add this to your user settings JSON (merge the entry into any existing onboarding.developerMode object):

"onboarding.developerMode": {
    "sessions.archiveNudge": true
}

Reload the window, then click Mark as Done in the nudge on an eligible session. With this override, the spotlight can show again after each window reload. Restore a session from Done, or use another session with a merged PR, to try again.

Do not forget to remove this override when you finish testing, so the normal once-per-user behavior is restored.

Screenshots

Mark as Done

First-use spotlight

[benibenj]

Megan Rogge (@meganrogge) In case the nudge doesn't show up. ask the agent to set the pr as an artifact. It should do it automatically unless you create the pr using the create pr button in the app. I'm working on a fix for that