Move helper types from settingsWidgets.ts to settingsWidgetsTypes.ts #281379
+170
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
…ences Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move out helpers in settingsWidgets.ts to a new file
Move helper types from settingsWidgets.ts to settingsWidgetsTypes.ts
Dec 4, 2025
Copilot finished work on behalf of
rzhao271
December 4, 2025 22:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted type definitions and interfaces from
settingsWidgets.tsinto a newsettingsWidgetsTypes.tsfile to improve code organization and maintainability.Changes
Created
settingsWidgetsTypes.ts: Contains all type definitions, interfaces, and type aliases previously embedded in settingsWidgets.tsISettingListChangeEvent,ISettingListAddEvent,ISettingListMoveEvent, etc.IListDataItem,IObjectDataItem,IIncludeExcludeDataItem,IBoolObjectDataItemObjectKey,ObjectValue,IObjectStringData,IObjectEnumData,IObjectBoolDataEditKey,RowElementGroup,IListViewItem, suggester interfacesUpdated
settingsWidgets.ts: Removed ~144 lines of type definitions, added imports from new file, re-exported public types for backwards compatibilityType ordering ensures no forward references. External consumers like
settingsTree.tsremain unchanged due to re-exports.Original prompt
Created from VS Code.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.