Restoring chat model if opening changes #281621
Open
+56
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Dec 5, 2025
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
Outdated
Show resolved
Hide resolved
rebornix
reviewed
Dec 5, 2025
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
Dec 5, 2025
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
Outdated
Show resolved
Hide resolved
| await session?.editingSession?.show(); | ||
| } else { | ||
| if (!session) { | ||
| await chatService.loadSessionForResource(resource, ChatAgentLocation.Chat, CancellationToken.None); |
Member
There was a problem hiding this comment.
This returned a reference too, who owns it?
Member
There was a problem hiding this comment.
Where is the command to show the changes implemented? I assume the session needs to stay alive as long as the diff editor is open, how are those two things associated?
Contributor
Author
There was a problem hiding this comment.
Changed it so that we keep a reference and dispose it accordingly.
This command is owned by the chat extension
roblourens
reviewed
Dec 5, 2025
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
Outdated
Show resolved
Hide resolved
…into osortega/restoring-model-if-disposed
roblourens
reviewed
Dec 6, 2025
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the model is restored before trying to open the diff changes