fix new line not working#318998
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where multi-paragraph plain text in chat responses was being merged into a single paragraph. The fast-path renderPlainTextMarkdown was wrapping any value without specific markdown syntax in a single <p>, which collapsed \n\n paragraph breaks via CSS whitespace normalization. Now any value containing a newline bypasses the fast path and goes through the full markdown renderer, which correctly produces separate <p> elements for paragraph breaks.
Changes:
- Reject strings containing
\nfrom the plain-text fast path so paragraph and line breaks are handled by the full markdown renderer.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentMarkdownRenderer.ts | Adds value.includes('\n') to the fast-path rejection condition. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
rzhao271
approved these changes
May 29, 2026
|
No unit tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #318845