Improve session action logs#319019
Merged
Merged
Conversation
lszomoru
approved these changes
May 29, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @sandy081Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Agents window session telemetry out of SessionsManagementService into a dedicated contribution, adding lifecycle events on the session management service and expanding logged session actions.
Changes:
- Adds new session management events for request sending and lifecycle actions.
- Introduces
SessionsTelemetryContributionto listen for service events and selected command executions. - Removes the old in-service telemetry reporter and registers the new contribution after workbench restore.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/services/sessions/test/browser/sessionNavigation.test.ts |
Updates the structural mock to satisfy the expanded session management interface. |
src/vs/sessions/services/sessions/common/sessionsManagement.ts |
Adds request telemetry payload and new lifecycle/request events to ISessionsManagementService. |
src/vs/sessions/services/sessions/browser/sessionsTelemetryReporter.ts |
Removes the old telemetry reporter implementation. |
src/vs/sessions/services/sessions/browser/sessionsManagementService.ts |
Replaces direct telemetry calls with event emitters around request and lifecycle operations. |
src/vs/sessions/contrib/sessions/browser/sessionsTelemetry.contribution.ts |
Adds the new telemetry contribution, payload helpers, classifications, and command-driven action logging. |
src/vs/sessions/contrib/sessions/browser/sessions.contribution.ts |
Registers the new telemetry contribution. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
| } else if (first && typeof first === 'object' && URI.isUri((first as { resource?: unknown }).resource)) { | ||
| resource = (first as { resource: URI }).resource; | ||
| } | ||
| return resource ? this._sessionsManagementService.getSession(resource) : undefined; |
Contributor
Screenshot ChangesBase: Added (15)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce new events for session management, including logging for sending requests, archiving, unarchiving, deleting sessions, and renaming chats.