Trim local agent system message so leading codespans render#319024
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes local agent system message rendering by trimming surrounding whitespace before wrapping the system message in markdown emphasis, allowing leading code spans to render correctly.
Changes:
- Trims system message content in
buildChatHistorybefore creating the markdown response part. - Adds a regression test covering leading/trailing whitespace around a system message containing a code span.
Show a summary per file
| File | Description |
|---|---|
extensions/copilot/src/extension/chatSessions/vscode-node/chatHistoryBuilder.ts |
Trims system message content before markdown formatting. |
extensions/copilot/src/extension/chatSessions/vscode-node/test/chatHistoryBuilder.spec.ts |
Adds regression coverage for whitespace-trimmed system message rendering. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
TylerLeonhardt
approved these changes
May 29, 2026
roblourens
reviewed
May 29, 2026
| const msg = messages[i]; | ||
| if (msg.message.role === 'system') { | ||
| const content = (msg.message as { role: 'system'; content: string }).content; | ||
| const content = (msg.message as { role: 'system'; content: string }).content.trim(); |
Member
There was a problem hiding this comment.
This doesn't look right. This looks like a claude code route and not a system notification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #318601
/cc @roblourens @meganrogge @justschen