Fix Rocky Linux devcontainer OS_ID parsing in check-requirements-linux.sh#319026
Open
saitejabandaru-in wants to merge 2 commits into
Open
Fix Rocky Linux devcontainer OS_ID parsing in check-requirements-linux.sh#319026saitejabandaru-in wants to merge 2 commits into
saitejabandaru-in wants to merge 2 commits into
Conversation
…x.sh Corrects parsing of quoted ID values in /etc/os-release by sourcing it in a POSIX-compliant subshell rather than using custom regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a known bug (issue #232159) where the remote devcontainer requirement checking script
check-requirements-linux.shfails on Linux distributions that use quotes in the/etc/os-releaseIDfield (e.g. Rocky Linux 8.5 whereID="rocky").Root Cause
The existing regex
ID=([^\"]+)fails to match whenID=is immediately followed by a double quote, resulting in an emptyOS_IDvalue.Solution
Instead of utilizing complex and error-prone regex/sed parsing, this PR leverages standard shell-native sourcing:
OS_ID="$(. /etc/os-release && echo "$ID")"Sourcing
/etc/os-releasein a POSIX-compliant subshell is extremely robust, fully supported across all Linux shells (bash, zsh, sh, ash, dash), and automatically strips surrounding quotes cleanly, regardless of whether they are present or not.