Browser: Favorites#319040
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Favorites support to the Integrated Browser, wiring favorite URLs into the URL bar, browser toolbar commands, storage, and styling.
Changes:
- Adds a browser favorites feature with persisted URL storage, URL picker suggestions, toolbar/keybinding actions, and a URL-bar favorite indicator.
- Updates URL bar behavior so Enter-committed text remains visible through blur until navigation commits.
- Adjusts browser URL picker/interface comments and adds styling for the favorite indicator.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/browserView/electron-browser/features/browserFavoritesFeature.ts |
Implements favorites storage, indicator UI, suggestions, and add/remove actions. |
src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts |
Registers the favorites feature contribution. |
src/vs/platform/browserView/common/browserView.ts |
Adds browser command IDs for adding/removing favorites. |
src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts |
Preserves Enter-committed URL text through the subsequent blur. |
src/vs/workbench/contrib/browserView/test/electron-browser/widgets/browserUrlBarWidget.test.ts |
Adds regression coverage for Enter commit plus blur behavior. |
src/vs/workbench/contrib/browserView/electron-browser/media/browser.css |
Styles the URL-bar favorite indicator button. |
src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts |
Updates URL suggestion/action documentation terminology for favorites. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 3
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
dmitrivMS
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318150