Draft: Display configurable context size limits in Language Models table#319062
Draft
eli-w-king wants to merge 1 commit into
Draft
Draft: Display configurable context size limits in Language Models table#319062eli-w-king wants to merge 1 commit into
eli-w-king wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Language Models management table to surface configurable context-size information and adjust the column ordering/labeling.
Changes:
- Reorders the table so Capabilities appears before context size.
- Renames and widens the context-size column to “Default Context Size”.
- Adds rendering and hover text for configurable maximum context sizes.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsWidget.ts |
Updates context-size rendering, hover content, schema parsing, and table column ordering. |
src/vs/workbench/contrib/chat/browser/chatManagement/media/chatModelsWidget.css |
Adjusts styling for the new configurable context-size text. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Comment on lines
+721
to
+724
| const max = Math.max(...numericValues); | ||
| const min = Math.min(...numericValues); | ||
| const schemaDefault = typeof contextSizeSchema.default === 'number' ? contextSizeSchema.default : undefined; | ||
| return { default: schemaDefault ?? min, max }; |
| const maxTotalTokens = maxConfigurableInput + outputTokens; | ||
| const maxDiv = DOM.append(templateData.tokenLimitsElement, $('.token-limit-item.token-limit-max')); | ||
| const maxText = DOM.append(maxDiv, $('span')); | ||
| maxText.textContent = localize('models.configurableContextSize', "Configurable to {0}", formatTokenCount(maxTotalTokens)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorders the columns in the Language Models table (Capabilities followed by Context Size), updates the header to "Default Context Size", and cleanly formats any configurable context maximum size limits without a colon (matching the default context number styling).