Skip to content

fix: mark 'Language model unavailable' as expected chat error (fixes #326356) #326357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vs-code-engineering wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: mark 'Language model unavailable' as expected chat error (fixes #326356) #326357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/vs/workbench/api/common/extHostChatAgents2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,13 @@ export class ExtHostChatAgents2 extends Disposable implements ExtHostChatAgentsS
if (!model) {
model = await this._languageModels.getDefaultLanguageModel(extension);
if (!model) {
throw new Error('Language model unavailable');
// No language model is available (e.g. the user is not signed in or no models
// have been contributed). This is an expected operational condition, not a bug,
// so mark it as a `ChatExpectedError` to keep it out of `chatAgentError` telemetry
// while still surfacing the user-facing message.
const error = new Error('Language model unavailable');
error.name = 'ChatExpectedError';
throw error;
}
}

Expand Down
Loading