Open
fix: preserve native browser shortcuts across keyboard layouts#326383
Conversation
…ndent) Co-authored-by: kycutler <67761731+kycutler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Ctrl+C/V/X functionality in integrated browser panel for Cyrillic layouts
fix: use Jul 17, 2026
event.code for browserView keyboard shortcuts to fix Ctrl+C/V/X under non-Latin layouts
kycutler
marked this pull request as ready for review
July 17, 2026 17:55
kycutler
enabled auto-merge (squash)
July 17, 2026 17:56
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes integrated-browser editing shortcuts under non-Latin keyboard layouts.
Changes:
- Uses
KeyboardEvent.codefor native browser shortcuts. - Updates macOS emoji-picker detection.
Show a summary per file
| File | Description |
|---|---|
preload-browserView.ts |
Changes native shortcut matching to physical key codes. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Collaborator
|
@copilot I've simplified the logic. Update the pr title / description |
Contributor
Author
Done. Updated the PR description to reflect the hybrid approach. Suggested new title: |
kycutler
changed the title
event.code for browserView keyboard shortcuts to fix Ctrl+C/V/X under non-Latin layouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under non-Latin keyboard layouts (for example, Cyrillic), native editing shortcuts such as
Ctrl+C,Ctrl+V, andCtrl+Xin the integrated browser were swallowed.event.keyproduces a non-Latin character in these layouts, so it did not match the preload script's Latin shortcut set.Changes
event.keyfor Latin letters, preserving remapped layouts such as AZERTY, Dvorak, and Colemak.event.codeonly whenevent.keyis non-Latin.This allows native editing shortcuts to reach Chromium under non-Latin layouts without regressing rearranged Latin layouts.
Fixes #326314