chore: onboard onto CFSClean#326394
Draft
rzhao271 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Onboards product builds onto CFSClean network isolation and ensures package authentication remains available on cache hits.
Changes:
- Enables the
CFSCleannetwork isolation policy. - Runs npm authentication regardless of node_modules cache state.
- Runs macOS PyPI authentication unconditionally.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
build/azure-pipelines/product-build.yml |
Enables CFSClean. |
build/azure-pipelines/win32/product-build-win32-node-modules.yml |
Makes npm authentication unconditional on cache state. |
build/azure-pipelines/web/product-build-web-node-modules.yml |
Makes npm authentication unconditional on cache state. |
build/azure-pipelines/linux/product-build-linux-node-modules.yml |
Makes npm authentication unconditional on cache state. |
build/azure-pipelines/darwin/product-build-darwin-node-modules.yml |
Makes npm and PyPI authentication unconditional on cache state. |
build/azure-pipelines/alpine/product-build-alpine-node-modules.yml |
Makes npm authentication unconditional on cache state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=456816&view=results
The CFSClean policy restricts access to public feeds, so I also changed the auth setup steps to run even when there is a node_modules cache available.