agentHost: preserve local IPC tool calls#326406
Merged
Merged
Conversation
Only arm protocol disconnect timeouts for clients that this server has observed disconnecting. Unknown client IDs may belong to local IPC and must remain pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves local IPC-owned tool calls by restricting disconnect timeouts to known disconnected protocol clients.
Changes:
- Ignore pending tool calls from unknown client IDs.
- Update disconnect/reconnect tests and add local IPC regression coverage.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/node/protocolServerHandler.ts |
Limits orphan timeouts to clients in protocol grace state. |
src/vs/platform/agentHost/test/node/protocolServerHandler.test.ts |
Updates timeout tests and covers active local IPC calls. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
Include the required turn start timestamp after updating the branch to current main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
justschen
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validation
npm run typecheck-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/protocolServerHandler.test.ts(68 passing)npm run precommit