fix: keep find view zone visible so Find does not cover text#326480
Open
cipheraxat wants to merge 3 commits into
Open
fix: keep find view zone visible so Find does not cover text#326480cipheraxat wants to merge 3 commits into
cipheraxat wants to merge 3 commits into
Conversation
The find widget sometimes left the first editor lines under the overlay because revealing often scrolled past the newly added top view zone, and model swaps cleared the zone id without reattaching it. Always keep the zone in the viewport when Find is open, reattach after model changes, and size the zone from the laid-out widget height. Fixes microsoft#316054
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Find widget’s top view zone so it consistently prevents the overlay from covering editor content.
Changes:
- Reattaches the view zone after model swaps.
- Keeps the zone visible when Find opens.
- Uses the laid-out widget height with a safe minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adjustScroll=false), instead of often scrolling past it when the selection was not under the find box.Fixes #316054
Test plan
editor.find.addExtraSpaceOnTop: true→ Cmd/Ctrl+F → first line sits below the find overlay (view zone height ~37px,scrollTop0)editor.find.addExtraSpaceOnTop: false→ no top view zone (zoneCount: 0)screenshots/316054/documenting oldadjustScroll=truecover vs fixed path