fix: avoid retained webview flash at default iframe size#326482
Open
cipheraxat wants to merge 3 commits into
Open
fix: avoid retained webview flash at default iframe size#326482cipheraxat wants to merge 3 commits into
cipheraxat wants to merge 3 commits into
Conversation
Defer OverlayWebview unhide until a connected CSS anchor is bound so retained custom editors do not briefly paint at ~300×150 on reveal.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents retained custom-editor webviews from briefly rendering at the iframe’s default size during reveal.
Changes:
- Defers overlay visibility until ownership and a connected CSS anchor are established.
- Binds editor anchors before claiming retained webviews.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
webviewEditor.ts |
Anchors webviews before claiming them. |
overlayWebview.ts |
Gates visibility on ownership and anchor connectivity. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retainContextWhenHidden) could briefly paint at the browser default iframe size (~300×150) when switching back from a text editor, becauseOverlayWebview._show()setvisibility: visiblebefore a connected CSS anchor was bound._updateVisibility), and bind the editor CSS anchor beforeclaimwhen the editor element is already connected.Test plan
retainContextWhenHiddencustom editor; open → switch to text tab → switch back; first visible overlay/iframe size matches editor bounds (no ≤320×180 flash across reveal samples)anchorElement.isConnected