chore: bump foundry-local-sdk to 2.x - #335329
Open
Raymond Zhao (rzhao271) wants to merge 8 commits into
Open
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The existing dictation runtime producer and loader remain incompatible with the SDK 2.x native layout.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bumps the Foundry Local SDK and simplifies native dependency installation in product pipelines.
Changes:
- Updates
foundry-local-sdkto 2.0.1. - Replaces custom installation helpers with SDK environment variables.
- Removes the SDK loader patch and obsolete pipeline scripts.
File summaries
| File | Description |
|---|---|
package.json |
Bumps and permits SDK 2.0.1 installation. |
package-lock.json |
Locks the SDK and updated transitive dependencies. |
build/npm/postinstall.ts |
Removes the custom native-loader patch. |
build/azure-pipelines/win32/steps/product-build-win32-compile.yml |
Configures Windows SDK installation. |
build/azure-pipelines/win32/sdl-scan-win32.yml |
Configures SDK installation for SDL scans. |
build/azure-pipelines/win32/product-build-win32-node-modules.yml |
Updates Windows dependency caching jobs. |
build/azure-pipelines/web/product-build-web.yml |
Configures web product dependency installation. |
build/azure-pipelines/web/product-build-web-node-modules.yml |
Updates web dependency caching jobs. |
build/azure-pipelines/product-quality-checks.yml |
Configures quality-check dependency installation. |
build/azure-pipelines/linux/steps/product-build-linux-compile.yml |
Configures Linux SDK installation. |
build/azure-pipelines/linux/product-build-linux-node-modules.yml |
Updates Linux dependency caching jobs. |
build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml |
Configures macOS SDK installation. |
build/azure-pipelines/darwin/product-build-darwin-node-modules.yml |
Updates macOS dependency caching jobs. |
build/azure-pipelines/common/foundryLocalInstall.ts |
Removes the custom native installer. |
build/azure-pipelines/common/foundry-local.yml |
Removes the obsolete installation template. |
build/azure-pipelines/common/disableFoundryLocalInstall.ts |
Removes the script-disabling helper. |
build/azure-pipelines/alpine/product-build-alpine.yml |
Configures Alpine SDK installation. |
build/azure-pipelines/alpine/product-build-alpine-node-modules.yml |
Updates Alpine dependency caching jobs. |
Review details
- Files reviewed: 17/18 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roblourens
previously approved these changes
Sep 9, 2026
roblourens
previously approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Cancellation, manager disposal, and cross-platform addon packaging issues remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 28/29 changed files
- Comments generated: 3
- Review effort level: Balanced
roblourens
reviewed
Sep 9, 2026
roblourens
left a comment
roblourens
left a comment
Member
There was a problem hiding this comment.
[Experimental performance review bot]
Automated experimental performance review.
(Written by Copilot)
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Martin Aeschlimann (aeschli)
previously approved these changes
Sep 10, 2026
Raymond Zhao (rzhao271)
requested review from
Megan Rogge (meganrogge)
and
a balanced review from Copilot
September 10, 2026 18:27
Copilot started reviewing on behalf of
Raymond Zhao (rzhao271)
September 10, 2026 18:28
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Worker cancellation and concurrent cache repair introduce races that can terminate a new session or temporarily remove a published runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 28/29 changed files
- Comments generated: 2
- Review effort level: Balanced
Megan Rogge (meganrogge)
previously approved these changes
Sep 10, 2026
Collaborator
Author
|
Bumping the milestone considering the complexity of this PR. |
Copilot started reviewing on behalf of
Raymond Zhao (rzhao271)
September 10, 2026 21:39
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The cross-platform native runtime, packaging, process lifecycle, and CI changes still require the pending product and CI verification.
Review details
- Files reviewed: 28/29 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Henning Dieterichs (hediet)
approved these changes
Sep 10, 2026
Vritant Bhardwaj (vritant24)
approved these changes
Sep 10, 2026
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Megan Rogge (meganrogge)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes several steps specific to the foundry-local-sdk package now that its post-installation process can be customized more with environment variables.