Use Dark 2026 for component fixtures - #335577
Merged
Henning Dieterichs (hediet) merged 3 commits intoSep 11, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Henning Dieterichs (hediet)
September 10, 2026 22:13
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The theme resource and its include chain are correctly bundled and loaded without affecting other fixture variants.
Review tier: Balanced
Findings: None
What changed in this PR
Updates component fixture screenshots to use the built-in Dark 2026 theme while retaining existing light and high-contrast themes.
Changes:
- Bundles Dark 2026 for fixture theme loading.
- Makes Dark 2026 the default dark fixture variant.
| File | Description |
|---|---|
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts |
Registers and selects Dark 2026 for component fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: The screenshot report exceeds GitHub's comment size limit. View the full report in the workflow summary. |
Henning Dieterichs (hediet)
force-pushed
the
hediet/component-fixture-dark-2026
branch
from
September 10, 2026 22:40
c7a4020 to
b23e936
Compare
Michael Lively (Yoyokrazy)
previously approved these changes
Sep 10, 2026
Henning Dieterichs (hediet)
enabled auto-merge (rebase)
September 10, 2026 22:44
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Henning Dieterichs (hediet)
force-pushed
the
hediet/component-fixture-dark-2026
branch
from
September 11, 2026 08:54
b23e936 to
31ab6a9
Compare
Giuseppe Cianci (Giuspepe)
previously approved these changes
Sep 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
approved these changes
Sep 11, 2026
Henning Dieterichs (hediet)
deleted the
hediet/component-fixture-dark-2026
branch
September 11, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is intentionally separate from the TextMate highlighting and diff/multi-diff work. Dark fixture screenshots are expected to change; layout and behavior are unchanged.
Validation
npm run transpile-clientnpm exec eslint -- src\vs\workbench\test\browser\componentFixtures\fixtureUtils.tsgit diff --check