chat: Make customizations multi-root workspace aware - #335592
Draft
Jessie Houghton (houghj16) wants to merge 1 commit into
Draft
chat: Make customizations multi-root workspace aware#335592Jessie Houghton (houghj16) wants to merge 1 commit into
Jessie Houghton (houghj16) wants to merge 1 commit into
Conversation
Group workspace customizations by folder, scope creation flows to the originating workspace, and consistently show source provenance in customization rows while moving descriptions to hovers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Jessie Houghton (houghj16)
September 10, 2026 23:15
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
AI generation remains unscoped, and source/description information has accessibility and remote-workspace regressions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 3
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationItemSource.ts — Preserve source paths for remote workspace files |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts — Propagate the originating folder to AI generation |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts — Expose MCP provenance in the row's ARIA label |
What changed in this PR
Makes AI customizations multi-root aware by grouping items per workspace folder and scoping manual creation flows.
Changes:
- Adds per-folder customization sections and source paths.
- Scopes manual customization and hook creation.
- Adds MCP provenance and updated tests/fixtures.
| File | Description |
|---|---|
aiCustomizationManagementEditor.fixture.ts |
Adds MCP source fixtures. |
hookActions.test.ts |
Tests workspace hook filtering. |
mcpListWidget.test.ts |
Tests provenance and hover text. |
customizationCreatorService.test.ts |
Tests folder-scoped creation locations. |
aiCustomizationListWidget.test.ts |
Tests grouping, paths, and creation context. |
hookActions.ts |
Scopes hook selection and creation. |
mcpListWidget.ts |
Displays MCP source provenance. |
customizationCreatorService.ts |
Filters and labels creation destinations. |
aiCustomizationManagementEditor.ts |
Propagates workspace-folder context. |
aiCustomizationListWidgetUtils.ts |
Uses filenames as secondary text. |
aiCustomizationListWidget.ts |
Adds per-folder grouping and actions. |
aiCustomizationItemSource.ts |
Removes workspace prefixes from labels. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
211
to
213
| filename: item.uri.scheme === Schemas.file | ||
| ? this.labelService.getUriLabel(item.uri, { relative: isWorkspaceItem }) | ||
| ? this.labelService.getUriLabel(item.uri, { relative: isWorkspaceItem, noPrefix: isWorkspaceItem }) | ||
| : basename(item.uri), |
| readonly kind?: 'generate'; | ||
| readonly target?: 'workspace' | 'user'; | ||
| run(): void; | ||
| run(workspaceFolder?: URI): void; |
Comment on lines
+268
to
+270
| const secondaryText = this.getSecondaryText(element); | ||
| templateData.description.textContent = secondaryText ?? ''; | ||
| templateData.description.style.display = secondaryText ? '' : 'none'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Customization page comparisons
Instructions
The row now shows the source path instead of the description, without repeating the workspace folder name. The description remains available in the row hover.
Hooks
Hooks are grouped by workspace folder and show their source paths. Creating a hook from a workspace section scopes the hook file choices and destination to that workspace.
Agents
Agents are grouped by workspace folder and show their source paths, with descriptions available in the row hover.
MCP Servers
MCP server rows now show the source path or
Plugin: <plugin name>instead of the description. The description remains available in the row hover when present.Skills workflow
Before
Proposal
Questions
.githubover.agentsin the quick pick and add a Recommended label?Testing
npm run compilescripts\test.bat --run src\vs\workbench\contrib\chat\test\browser\aiCustomization\aiCustomizationListWidget.test.ts --run src\vs\workbench\contrib\chat\test\browser\aiCustomization\customizationCreatorService.test.ts --run src\vs\workbench\contrib\chat\test\browser\aiCustomization\mcpListWidget.test.ts --run src\vs\workbench\contrib\chat\test\browser\promptSyntax\hookActions.test.ts(90 passing)git diff --checkFixes #332290
Fixes #333755
Addresses #332543