eslint: allow bracket notation for process.env

[Alexandru Dima (alexdima)]

Summary

Add one small built-in exception to local/code-no-bracket-notation-for-identifiers for environment-variable names accessed directly through process.env:

process.env['ProgramW6432'];
process.env['PROGRAMFILES'];
process.env['https_proxy'];

The exception covers reads, writes, deletes, and direct optional chaining. Dot notation remains valid as well.

• No new rule options, receiver-path machinery, or ESLint configuration changes.
• No exceptions for aliases, safeProcess.env, opts, or other receivers.
• Existing ordinary/private-member checks and autofixes stay in place.
• Remove the misleading blanket claim that bracket notation bypasses type checking.

This supersedes the earlier configurable approach discussed in #334768. The final diff contains only the existing rule and its tests: no application-source notation conversions or migration-allowlist changes.

Validation

• Focused rule tests: 34 passed
• Targeted TypeScript 6 checking for the rule and tests
• ESLint with --max-warnings=0
• Targeted repository hygiene and normal pre-commit hooks
• git diff --check

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation is focused, consistent with the stated scope, and comprehensively tested.

Review tier: Balanced
Findings: None

What changed in this PR

Adds scoped bracket-notation exceptions for dictionary-like receivers while preserving enforcement elsewhere.

Changes:

• Adds exact structural receiver matching to the ESLint rule.
• Configures global and file-specific receiver exceptions.
• Adds rule and configuration regression tests.

File	Description
.eslint-plugin-local/​code-no-bracket-notation-for-identifiers.ts	Implements configurable receiver-path exceptions.
eslint.config.js	Defines environment and file-scoped exceptions.
build/​lib/​test/​codeNoBracketNotationForIdentifiers.test.ts	Tests matching, enforcement, autofixes, and configuration scope.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.