Support session configuration controls on remote AHP hosts - #335599
Open
Osvaldo Ortega (osortega) wants to merge 4 commits into
Open
Support session configuration controls on remote AHP hosts#335599Osvaldo Ortega (osortega) wants to merge 4 commits into
Osvaldo Ortega (osortega) wants to merge 4 commits into
Conversation
Copilot started reviewing on behalf of
Osvaldo Ortega (osortega)
September 11, 2026 00:06
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts — Restore static fallback when dynamic completions fail |
|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostUntitledProvisionalSessionService.ts — Reconcile the runtime behavior change with the PR scope |
What changed in this PR
The diff adds remote session-owner routing and generic session-config picker support, despite the PR description presenting it as logging-only.
Changes:
- Routes subscriptions, dispatches, and config refreshes through owning hosts.
- Adds mutable generic configuration chips and stale-selection protection.
- Expands remote-session tests and fixtures.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostUntitledProvisionalSessionService.test.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostGenericConfigChips.test.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatInputPicker.test.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostUntitledProvisionalSessionService.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionUri.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostGenericConfigChips.ts | Updated as part of this pull request. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts | Updated as part of this pull request. |
| src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostModePicker.fixture.ts | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Recover early configuration subscriptions when the host announces the session, and retain schema options when dynamic lookups fail. Preserve cancellation and stale-target handling, with regression coverage for both paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Osvaldo Ortega (osortega)
marked this pull request as ready for review
September 11, 2026 00:59
Osvaldo Ortega (osortega)
enabled auto-merge (squash)
September 11, 2026 00:59
Register the connection resolver with inert local and remote fixture services so chat input fixtures can construct the generic configuration controls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Don Jayamanne (DonJayamanne)
previously approved these changes
Sep 11, 2026
Contributor
Screenshot ChangesBase: Changed (22)2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Errored (4)Fixtures that failed to render — no screenshot was produced.
|
Preserve upstream sandbox OS detection and combined-picker changes while retaining remote session configuration routing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alexandru Dima (alexdima)
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Enable the existing schema-driven session configuration controls for remote AHP sessions in the Agents Window.
This is a functional client routing and UI change, not a diagnostics-only change. The generic configuration controls previously recognized only local session resources and used the ambient agent-host connection. As a result, remote sessions could advertise editable configuration without exposing usable generic controls.
Changes
IAgentHostConnectionsServiceand use its owning connection for configuration subscriptions, dynamic option completions, andsession/configChangedwrites.Scope
The temporary investigation diagnostics have been removed. This change does not add a permissions adapter, host-specific permission-name mapping, host-version workaround, new protocol capability, or new telemetry. AHP schema metadata determines which generic controls are available and editable.
Validation