fix: re-assert active editor context on workspace trust change - #335615
Open
Birarpanjot Singh Kanwer (arpankanwer) wants to merge 1 commit into
Open
fix: re-assert active editor context on workspace trust change#335615Birarpanjot Singh Kanwer (arpankanwer) wants to merge 1 commit into
Birarpanjot Singh Kanwer (arpankanwer) wants to merge 1 commit into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Birarpanjot Singh Kanwer (arpankanwer)
force-pushed
the
fix/save-greyed-after-trust-335608
branch
from
September 11, 2026 02:51
191a648 to
6f5e685
Compare
Fixes microsoft#335608 Re-observes the active editor when workspace trust changes so File > Save precondition on activeEditor context re-evaluates without requiring an editor switch.
Birarpanjot Singh Kanwer (arpankanwer)
force-pushed
the
fix/save-greyed-after-trust-335608
branch
from
September 11, 2026 02:53
6f5e685 to
dac5d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335608
Bug repro
Root cause
Workspace trust transitions do not fire active-editor events, so stale activeEditor context keys persist. File > Save precondition on that context never re-evaluates until the active editor changes.
Fix
Re-observe the active editor on workspaceTrustService.onDidChangeTrust in EditorGroupView, re-asserting context keys immediately after a trust transition.
Validation