Allow leaving PR comments in agents - #335648
Open
Alex Ross (alexr00) wants to merge 2 commits into
Open
Conversation
Alex Ross (alexr00)
requested a review
from Benjamin Christopher Simmonds (benibenj)
September 11, 2026 08:52
Alex Ross (alexr00)
marked this pull request as ready for review
September 11, 2026 08:52
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unpaginated GitHub responses prevent commenting on pending reviews and files beyond API page limits.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts — Support changed files beyond the compare API cap |
|
src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts — Find pending reviews beyond the first REST page |
What changed in this PR
Adds pull-request line commenting to the Agents Window and integrates new comments with Agent Host feedback annotations.
Changes:
- Adds GitHub APIs and models for line-level review comments.
- Maps editor lines to commentable pull-request diff lines.
- Updates Agent Feedback UI, synchronization, configuration, and tests.
| File | Description |
|---|---|
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts |
Updates the feedback service fixture. |
src/vs/workbench/contrib/comments/browser/commentsController.ts |
Disables native comment handling in Sessions windows. |
src/vs/sessions/contrib/github/test/browser/githubModels.test.ts |
Tests model-level review comment posting. |
src/vs/sessions/contrib/github/test/browser/githubFetchers.test.ts |
Tests review-comment API requests and review mapping. |
src/vs/sessions/contrib/github/common/types.ts |
Adds patch and review-node metadata. |
src/vs/sessions/contrib/github/browser/models/githubPullRequestModel.ts |
Exposes review comment posting. |
src/vs/sessions/contrib/github/browser/githubService.ts |
Adds GitHub file-content retrieval. |
src/vs/sessions/contrib/github/browser/fetchers/githubPRFetcher.ts |
Implements pending and new review comments. |
src/vs/sessions/contrib/github/browser/fetchers/githubChangesFetcher.ts |
Preserves unified patches. |
src/vs/sessions/contrib/codeReview/test/browser/codeReviewService.test.ts |
Tests line mapping and comment creation. |
src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts |
Resolves and posts PR comment targets. |
src/vs/sessions/contrib/changes/test/browser/agentsDiffEditor.fixture.ts |
Registers the review service fixture. |
src/vs/sessions/contrib/agentFeedback/test/browser/sessionEditorComments.test.ts |
Tests annotation authority over raw comments. |
src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackService.test.ts |
Tests raw-comment visibility before loading. |
src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackItemsBackend.test.ts |
Tests optimistic annotation mutations. |
src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackInputWidget.fixture.ts |
Registers the review service fixture. |
src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.test.ts |
Tests deletion of mirrored PR comments. |
src/vs/sessions/contrib/agentFeedback/browser/sessionEditorComments.ts |
Prefers Agent Host comment annotations. |
src/vs/sessions/contrib/agentFeedback/browser/nullAgentFeedbackService.contribution.ts |
Implements the new session-type method. |
src/vs/sessions/contrib/agentFeedback/browser/feedbackInputWidget.ts |
Supports dynamic action labels. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts |
Exposes Agent Host session detection. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackPRReviewSeeder.ts |
Makes annotations authoritative comment mirrors. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackItemsBackend.ts |
Adds optimistic annotation caching and reconciliation. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts |
Applies raw-comment visibility rules. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidget.ts |
Suppresses deleted mirrored source comments. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts |
Applies annotation authority to overlays. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts |
Adds PR target selection and submission UI. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts |
Applies annotation authority during navigation. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedback.contribution.ts |
Registers the experimental feature setting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (32)
|
| Before | After |
|---|---|
 |
 |
editor/inlineChatAffordance/InlineChatAffordance/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbar/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbar/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbarHovered/Dark
| Before | After |
|---|---|
|
|
editor/inlineCompletions/other/HintsToolbarHovered/Light
| Before | After |
|---|---|
|
|
editor/inlineCompletions/views/SideBySideViewSmall/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewSmall/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewWide/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewWide/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/WordReplacementView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/WordReplacementView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/DeletionView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/DeletionView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/LineReplacementView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/LineReplacementView/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditor/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditor/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalPending/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalPending/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalResolved/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalResolved/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorDocumentSwapAfter/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorDocumentSwapAfter/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletionsWithDetails/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletionsWithDetails/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiff/multiDiffEditorScroll/RealWidget/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiff/multiDiffEditorScroll/RealWidget/Light
| Before | After |
|---|---|
 |
 |
peekReference/PeekReferences/Dark
| Before | After |
|---|---|
 |
 |
peekReference/PeekReferences/Light
| Before | After |
|---|---|
 |
 |
3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Errored (8)
Fixtures that failed to render — no screenshot was produced.
sessions/agentFeedback/agentFeedbackEditorWidget/LongFileTwoComments/Dark — [ComponentFixture] Dark virtual-time history (4 tasks):
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AgentFeedbackEditorWidgetContribution._rebuildWidgets (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:119:36)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:84:9)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackEditorWidgetContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:76:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at renderViaContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.fixture.ts:346:45)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.fixture.ts:528:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
sessions/agentFeedback/agentFeedbackEditorWidget/LongFileTwoComments/Light — [ComponentFixture] Light virtual-time history (4 tasks):
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AgentFeedbackEditorWidgetContribution._rebuildWidgets (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:119:36)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:84:9)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackEditorWidgetContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:76:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at renderViaContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.fixture.ts:346:45)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.fixture.ts:528:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
sessions/agentFeedback/agentFeedbackInputWidget/InEditor/Dark — this._agentFeedbackService.isAgentHostSession is not a function
TypeError: this._agentFeedbackService.isAgentHostSession is not a function
at AgentFeedbackEditorInputContribution._selectLine (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts:524:52)
at AgentFeedbackEditorInputContribution.showAtCurrentLine (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts:482:13)
at renderInEditor (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackInputWidget.fixture.ts:208:15)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackInputWidget.fixture.ts:249:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
sessions/agentFeedback/agentFeedbackInputWidget/InEditor/Light — this._agentFeedbackService.isAgentHostSession is not a function
TypeError: this._agentFeedbackService.isAgentHostSession is not a function
at AgentFeedbackEditorInputContribution._selectLine (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts:524:52)
at AgentFeedbackEditorInputContribution.showAtCurrentLine (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts:482:13)
at renderInEditor (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackInputWidget.fixture.ts:208:15)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackInputWidget.fixture.ts:249:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
sessions/changes/agentsDiffEditor/CompactDiffWithFeedback/Dark — [ComponentFixture] Dark virtual-time history (33 tasks):
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AgentFeedbackEditorWidgetContribution._rebuildWidgets (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:119:36)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:84:9)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackEditorWidgetContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:76:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at CodeEditorContributions._instantiateById (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:156:48)
at CodeEditorContributions._instantiateSome (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:129:9)
at callback (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:75:9)
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1186:9)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
sessions/changes/agentsDiffEditor/CompactDiffWithFeedback/Light — [ComponentFixture] Light virtual-time history (33 tasks):
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AgentFeedbackEditorWidgetContribution._rebuildWidgets (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:119:36)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:84:9)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackEditorWidgetContribution (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts:76:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at CodeEditorContributions._instantiateById (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:156:48)
at CodeEditorContributions._instantiateSome (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:129:9)
at callback (file:///home/runner/work/vscode/vscode/src/vs/editor/browser/widget/codeEditor/codeEditorContributions.ts:75:9)
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1186:9)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
sessions/changes/agentsDiffEditor/CompactDiffWithSubmitOverlay/Dark — agentFeedbackService.isAgentHostSession is not a function
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts:102:38)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackOverlayController (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts:89:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at renderAgentsDiffEditor (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/changes/test/browser/agentsDiffEditor.fixture.ts:304:49)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/changes/test/browser/agentsDiffEditor.fixture.ts:360:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
sessions/changes/agentsDiffEditor/CompactDiffWithSubmitOverlay/Light — agentFeedbackService.isAgentHostSession is not a function
Error: agentFeedbackService.isAgentHostSession is not a function
TypeError: agentFeedbackService.isAgentHostSession is not a function
at shouldIncludeRawPRReviewComments (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts:300:31)
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts:102:38)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentFeedbackOverlayController (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts:89:26)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at renderAgentsDiffEditor (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/changes/test/browser/agentsDiffEditor.fixture.ts:304:49)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/sessions/contrib/changes/test/browser/agentsDiffEditor.fixture.ts:360:22)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1199:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1242:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.