[wip] Add local canvases to the Agents Window - #335902
Draft
Ulugbek Abdullaev (ulugbekna) wants to merge 6 commits into
Draft
[wip] Add local canvases to the Agents Window#335902Ulugbek Abdullaev (ulugbekna) wants to merge 6 commits into
Ulugbek Abdullaev (ulugbekna) wants to merge 6 commits into
Conversation
Copilot started reviewing on behalf of
Ulugbek Abdullaev (ulugbekna)
September 11, 2026 22:11
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Workspace-scoped approvals can bypass target-folder trust checks and fail for isolated worktrees because repository roots are used instead of effective working directories.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (3)
What changed in this PR
Adds an opt-in local canvas development preview spanning Agent Host state, package authorization, Sessions UI, and confined Integrated Browser rendering.
Changes:
- Adds canonical canvas protocol, persistence, context, and SDK integration.
- Adds reviewed package snapshots with scoped approvals.
- Adds Sessions controls, browser confinement, tooling, and tests.
| File | Description |
|---|---|
src/vs/platform/agentHost/** |
Canvas protocol, runtime, package authorization, context, and tests |
src/vs/sessions/contrib/canvases/** |
Canvas presentation and actions |
src/vs/sessions/contrib/providers/agentHost/** |
Package management and session integration |
src/vs/workbench/contrib/browserView/** |
Source-backed browser editors |
src/vs/platform/browserView/** |
Native browser confinement and lifecycle |
src/vs/workbench/contrib/chat/** |
Canvas request context and draft transfer |
scripts/local-canvas-* |
Development setup and launch tooling |
.agents/skills/launch/** |
Isolated launch workflow updates |
build/** |
Build, localization, and style metadata |
src/**/test/** |
Unit and integration coverage |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add the default-off local canvas preview across Agent Host, the canonical protocol adapter, Sessions presentation, package authoring and native browser surfaces. Preserve exact workspace/revision authority, external document data, canvas-first retention, live source ownership and request-frozen context. Project genuine joined-SDK requests into chat turns so canvas-originated requests use visible tool approvals and cancellation. Include regression coverage, runnable fixtures, launch tooling and the required JavaScript allowlist entries for source packages that run without transpilation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
Ulugbek Abdullaev (ulugbekna)
force-pushed
the
ulugbekna/agents/gh-copilot-canvases-support-vscode
branch
from
September 13, 2026 15:30
5de6afa to
730ecfb
Compare
Supply the upstream primary-view observable in the canvas binding fixture. Resolve the public SDK through Node in the Electron test runner, and accept the two platform fetch error messages for retired endpoints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
Contributor
|
Base:
|
Fix the noUnusedLocals error reported by the complete CI compilation after switching dependency resolution to Node. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
Scope launch retirement to captured working directories and refresh newly approved canvas catalogs without another turn. Correct Windows file identity and snapshot reuse, and prove child termination directly across platforms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
Replace remaining Unix-only exit-audit assumptions with observed process state. Prove the old backend is gone before checking endpoint unavailability, independently of platform-specific fetch errors. Give the 2048-file production-quota fixture an explicit I/O budget without changing its thresholds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
Register the real fixture-local view-state service required by NewChatView. All 42 affected themed fixtures render and dispose without errors; keep the existing blocking screenshot baselines unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a069b1a2-65a9-4427-b3fe-6546a3bffc9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a default-off local canvas development preview to the Agents Window, backed by approved Copilot SDK extension packages and source-resolved native browser surfaces.
This is a work-in-progress integration PR, not a request to enable the feature generally or publish the companion SDK/runtime changes.
Included
The five JavaScript allowlist additions are executable extension/browser fixtures and the no-build authoring starter; those files intentionally run as delivered rather than requiring TypeScript transpilation. The allowlist still requires normal CODEOWNERS review.
Validation
Public companion drafts
46a47524.The compatible runtime change is tracked separately in its existing private repository.
Remaining WIP gates
Hook processor is not configuredresume failure was fixed in the companion runtime's lifecycle handling, without a VS Code workaround. Repeated unchanged SDK reproductions and actual native existing-chat package approval now pass. Consuming released dependency versions is still separate from the isolated development-build validation.Review and verification follow-up (2026-09-13)
5d9864b8adb, including compile, unit, browser, integration and smoke checks across Windows, macOS and Linux.NewChatViewrequired the view-state service but the new-chat fixture did not register it. Signed follow-up5d9864b8adbadds that real fixture-local service. All 42 affected Dark/Light fixtures render and dispose without errors; representative composers and attachment controls render again. All 16 blank-image baseline replacements were rejected, and no blocking hashes were changed. Exact-head screenshot/fixture CI passes, as does exact-head platform CI. Only the human PR review policy remains pending here.No private user profiles, credentials, local verification logs, heap dumps, SDK/runtime build artifacts or session documents are included.