Improve benchmark telemetry and dev-server watching - #521
Merged
Mohamed Mansour (mohamedmansour) merged 2 commits intoSep 4, 2026
Conversation
Stabilize development file watching and present server benchmark telemetry with compact peak memory and CPU summaries plus structured details. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mohamed Mansour (mohamedmansour)
requested review from
Bang Lee (Qusic),
Akrosh Gandhi (akroshg) and
mcritzjam
and
a lite review from Copilot
September 4, 2026 03:46
Copilot started reviewing on behalf of
Mohamed Mansour (mohamedmansour)
September 4, 2026 03:46
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new watcher access-event filter is currently too broad and can suppress write-close access events, risking missed rebuilds on some backends.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the docs benchmark explorer to surface comparable server resource telemetry (Peak RSS and CPU/request) and improves the dev-server file watcher to avoid unnecessary rebuild triggers from access-only events, directory metadata noise, and pnpm symlink canonicalization.
Changes:
- Enhance benchmark explorer UI to show server telemetry summaries and a structured “Details” disclosure, including parsed benchmark detail segments.
- Switch benchmark explorer’s default metric to No Streaming RPS and adjust ranking/detail presentation accordingly.
- Update dev-server watcher to (a) avoid recursive symlink traversal, (b) suppress access-only events earlier, and (c) preserve lexical
node_modulesignores for pnpm symlink trees, with added regression tests.
File summaries
| File | Description |
|---|---|
| docs/.webui-press/components/benchmark-explorer/benchmark-explorer.ts | Adds detail parsing + DOM enhancement to present structured benchmark “Details”; changes default metric. |
| docs/.webui-press/components/benchmark-explorer/benchmark-explorer.html | Expands benchmark rows to include server telemetry summary + lifecycle details for RPS metrics and reorganizes detail presentation. |
| docs/.webui-press/components/benchmark-explorer/benchmark-explorer.css | Adds layout/styling for telemetry columns, responsive details panels, and updated row layout/borders. |
| crates/webui-dev-server/src/watch.rs | Adds access-event filtering wrapper watcher, disables symlink following, filters directory events, and improves ignore matching for pnpm symlink paths with new tests. |
Review details
Suppressed comments (1)
crates/webui-dev-server/src/watch.rs:435
- The unit test for
is_access_eventcurrently assertsAccessKind::Anyis filtered. Ifis_access_eventis narrowed to read-only access (to avoid suppressingClose(Write)), adjust the test to assert read access is filtered and write-close is not.
fn access_events_are_not_content_changes() {
use notify::event::{AccessKind, ModifyKind};
assert!(is_access_event(&Event::new(EventKind::Access(
AccessKind::Any
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mcritzjam
approved these changes
Sep 4, 2026
Mohamed Mansour (mohamedmansour)
deleted the
mmansour-microsoft-potential-journey
branch
September 4, 2026 04:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark homepage needs server resource data that remains easy to compare, and the docs development server must stay idle when recursive watchers encounter read-only activity through workspace links.
Summary
node_modulesexclusions for linked pnpm workspaces.Validation
cargo xtask check