Skip to content

Improve benchmark telemetry and dev-server watching - #521

Merged
Mohamed Mansour (mohamedmansour) merged 2 commits into
mainfrom
mmansour-microsoft-potential-journey
Sep 4, 2026
Merged

Improve benchmark telemetry and dev-server watching#521
Mohamed Mansour (mohamedmansour) merged 2 commits into
mainfrom
mmansour-microsoft-potential-journey

Conversation

@mohamedmansour

Copy link
Copy Markdown
Contributor

The benchmark homepage needs server resource data that remains easy to compare, and the docs development server must stay idle when recursive watchers encounter read-only activity through workspace links.

Summary

  • Filter access-only and existing-directory watcher events before debounce, disable recursive symlink traversal, and retain lexical node_modules exclusions for linked pnpm workspaces.
  • Add regression coverage for read events and pnpm-style symlink trees.
  • Publish regenerated benchmark telemetry with compact Peak RSS and CPU/request columns for RPS rankings.
  • Move benchmark methodology and complete server resource lifecycle values into an accessible, responsive Details disclosure.
  • Correct the benchmark explorer default to No Streaming RPS and keep metric-specific ranking updates structured.

Validation

  • cargo xtask check

Stabilize development file watching and present server benchmark telemetry with compact peak memory and CPU summaries plus structured details.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new watcher access-event filter is currently too broad and can suppress write-close access events, risking missed rebuilds on some backends.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the docs benchmark explorer to surface comparable server resource telemetry (Peak RSS and CPU/request) and improves the dev-server file watcher to avoid unnecessary rebuild triggers from access-only events, directory metadata noise, and pnpm symlink canonicalization.

Changes:

  • Enhance benchmark explorer UI to show server telemetry summaries and a structured “Details” disclosure, including parsed benchmark detail segments.
  • Switch benchmark explorer’s default metric to No Streaming RPS and adjust ranking/detail presentation accordingly.
  • Update dev-server watcher to (a) avoid recursive symlink traversal, (b) suppress access-only events earlier, and (c) preserve lexical node_modules ignores for pnpm symlink trees, with added regression tests.
File summaries
File Description
docs/.webui-press/components/benchmark-explorer/benchmark-explorer.ts Adds detail parsing + DOM enhancement to present structured benchmark “Details”; changes default metric.
docs/.webui-press/components/benchmark-explorer/benchmark-explorer.html Expands benchmark rows to include server telemetry summary + lifecycle details for RPS metrics and reorganizes detail presentation.
docs/.webui-press/components/benchmark-explorer/benchmark-explorer.css Adds layout/styling for telemetry columns, responsive details panels, and updated row layout/borders.
crates/webui-dev-server/src/watch.rs Adds access-event filtering wrapper watcher, disables symlink following, filters directory events, and improves ignore matching for pnpm symlink paths with new tests.
Review details

Suppressed comments (1)

crates/webui-dev-server/src/watch.rs:435

  • The unit test for is_access_event currently asserts AccessKind::Any is filtered. If is_access_event is narrowed to read-only access (to avoid suppressing Close(Write)), adjust the test to assert read access is filtered and write-close is not.
    fn access_events_are_not_content_changes() {
        use notify::event::{AccessKind, ModifyKind};

        assert!(is_access_event(&Event::new(EventKind::Access(
            AccessKind::Any
  • Files reviewed: 4/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/webui-dev-server/src/watch.rs Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mohamedmansour
Mohamed Mansour (mohamedmansour) merged commit c53a3e5 into main Sep 4, 2026
35 checks passed
@mohamedmansour
Mohamed Mansour (mohamedmansour) deleted the mmansour-microsoft-potential-journey branch September 4, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants