fix: prevent RUSTFLAGS from leaking into downstream cargo-make rust-script builds

[wmmc88]

Problem

When downstream consumers of wdk-build (e.g. microsoft/Windows-rust-driver-samples) run cargo make, RUSTFLAGS=-D warnings leaks into rust-script compilation of the inline build scripts. This causes warnings in the published wdk-build crate to become hard errors, breaking downstream CI.

Example failure (from Windows-rust-driver-samples Build CI):

error: the feature `assert_matches` has been stable since 1.95.0-nightly
  --> wdk-build-0.5.1/src/lib.rs:13:40
   = note: `-D stable-features` implied by `-D warnings`

Root Cause

The rust-script tasks in rust-driver-makefile.toml specify wdk-build = { path = ".", version = "0.5.1" }. Cargo always uses path when both are specified, ignoring version. When load_rust_driver_makefile() symlinks the makefile from the registry cache, path = "." resolves to the registry source via --base-path, making wdk-build a path dependency. Cargo does not apply --cap-lints allow to path dependencies, so RUSTFLAGS=-D warnings applies directly to the published crate.

Normal cargo build is unaffected because wdk-build is resolved as a registry dependency there.

Fix

1. load_wdk_build_makefile() now checks package.source from cargo_metadata:

   • Registry dep (source.is_some()): Copies the makefile and rewrites wdk-build = { path = "." } to wdk-build = "X.Y.Z" (version from metadata). This ensures cargo treats it as a registry dep and applies --cap-lints allow.
   • Path/workspace dep (source.is_none()): Preserves existing symlink behavior so local development works correctly.

2. Removed unused version field from all 14 rust-script dep specs in rust-driver-makefile.toml and rust-driver-sample-makefile.toml, since path always takes precedence. Added a comment explaining the automatic rewrite by load_rust_driver_makefile().

Scenarios

Scenario	package.source	Behavior
Upstream WDR dev	N/A (uses extend, not load_*)	Unchanged
Downstream registry dep	Some(registry+...)	Copy + rewrite -> registry dep -> --cap-lints
Downstream path dep	None	Symlink preserved -> path dep (intentional)

[Copilot]

Pull request overview

This PR prevents downstream cargo make consumers of wdk-build from inheriting caller RUSTFLAGS (e.g. -D warnings) into rust-script compilation of embedded scripts by ensuring wdk-build is treated as a non-path dependency when loaded from the registry.

Changes:

• Update load_wdk_build_makefile() to copy+rewrite embedded rust-script manifests from wdk-build = { path = "." } to wdk-build = "X.Y.Z" when wdk-build is resolved from a non-path source.
• Preserve existing symlink behavior when wdk-build is a workspace/path dependency to keep local dev flows intact.
• Remove redundant version = "...“ fields from rust-script embedded dependency specs and add an explanatory note in the main makefile.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
crates/wdk-build/src/cargo_make.rs	Implements registry-vs-path behavior (copy+rewrite vs symlink) when materializing makefiles into target/.
crates/wdk-build/rust-driver-makefile.toml	Removes redundant embedded dependency versions and documents the downstream rewrite behavior.
crates/wdk-build/rust-driver-sample-makefile.toml	Removes redundant embedded dependency versions from sample tasks.

Comments suppressed due to low confidence (2)

crates/wdk-build/src/cargo_make.rs:934

• The rewrite uses a simple replace without validating that any occurrences were actually patched. If the makefile format changes (spacing/comments/features), this will silently leave the path = "." dependency intact and the original lint-leak issue will persist. Consider checking whether patched_content differs from makefile_content and returning a ConfigError (or at least logging) when no replacement occurred.

        let version = &wdk_build_package.version;
        let patched_content = makefile_content.replace(
            r#"wdk-build = { path = "." }"#,
            &format!("wdk-build = \"{version}\""),
        );

crates/wdk-build/src/cargo_make.rs:927

• load_wdk_build_makefile now sometimes writes a patched copy into target/ instead of always creating/updating a symlink. The rustdoc/comments above this function (and the public load_*_makefile wrappers) still describe the behavior as always symlinking; they should be updated to reflect the new copy+rewrite path for registry dependencies.

    if wdk_build_package.source.is_some() {
        // wdk-build is a registry (or git) dependency. Rewrite path dependencies in
        // the makefile's rust-script embedded manifests to version-only dependencies so
        // that cargo treats wdk-build as a registry dep and applies --cap-lints. This
        // prevents the caller's RUSTFLAGS (e.g. -D warnings) from leaking into the
        // published wdk-build crate's compilation.
        let makefile_content = std::fs::read_to_string(&rust_driver_makefile_toml_path)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.21429% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.63%. Comparing base (666875a) to head (bc34e25).

Files with missing lines	Patch %	Lines
crates/wdk-build/src/cargo_make.rs	93.21%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   77.42%   78.63%   +1.21%     
==========================================
  Files          24       24              
  Lines        4851     5117     +266     
  Branches     4851     5117     +266     
==========================================
+ Hits         3756     4024     +268     
+ Misses        978      976       -2     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.