Skip to content

Fix cpprest checked iterator build error#6301

Merged
florelis merged 4 commits into
microsoft:masterfrom
Trenly:CppRestSDKFix
Jun 29, 2026
Merged

Fix cpprest checked iterator build error#6301
florelis merged 4 commits into
microsoft:masterfrom
Trenly:CppRestSDKFix

Conversation

@Trenly

@Trenly Trenly commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Adds a patch for cpprestsdk to allow it to build in VS2026 18.5.3

🔗 References

🔍 Validation

Built locally

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner June 19, 2026 19:16
@florelis

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@florelis

Copy link
Copy Markdown
Member

Could you add a note about this new patch to the overlay README, please? And also a comment somewhere about what the patch is about.

@florelis

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/VcpkgPortOverlay/CreatePortOverlay.ps1 Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 26, 2026
@Trenly Trenly mentioned this pull request Jun 29, 2026
@Trenly Trenly requested a review from florelis June 29, 2026 03:04
@florelis

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@florelis

florelis commented Jun 29, 2026

Copy link
Copy Markdown
Member

I just remembered that we need to update the cgmanifest.json for this. I'll do it in a separate PR just so we don't need to have yet another round of review for this one

Edit: never mind, the base commit is still the same, it just has another patch on top

@florelis florelis merged commit 1781ce7 into microsoft:master Jun 29, 2026
9 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jun 29, 2026
@Trenly Trenly deleted the CppRestSDKFix branch June 29, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation for cpprestsdk fails on Visual Studio 18.5.3

3 participants