Skip to content

Add persistent output locale override setting#6310

Open
Trenly wants to merge 9 commits into
microsoft:masterfrom
Trenly:trenly/fix-422-output-locale-override
Open

Add persistent output locale override setting#6310
Trenly wants to merge 9 commits into
microsoft:masterfrom
Trenly:trenly/fix-422-output-locale-override

Conversation

@Trenly

@Trenly Trenly commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Add a persistent output.locale user setting that allows overriding WinGet interface language via a BCP47 tag.

This PR also ensures the override affects MRT resource resolution by setting both ApplicationLanguages::PrimaryLanguageOverride and the global Language qualifier, and updates packaging so local builds can include localized winget.resw files from Localization\Resources\<locale> when Shared\Strings\<locale> is absent.

🔗 References

Resolves #422

🔍 Validation

  • Built locally and confirmed settings are read and locale override is applied at startup.
  • No additional automated tests were run in-agent.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

* Add output.locale setting and schema support
* Apply runtime language qualifier override for resource resolution
* Include localized resw fallbacks in dev package and update docs/release notes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Trenly Trenly changed the base branch from release-v1.29 to master June 21, 2026 04:51
@microsoft-github-policy-service microsoft-github-policy-service Bot added Issue-Feature This is a feature request for the Windows Package Manager client. Area-Settings Issue related to WinGet Settings labels Jun 21, 2026
Comment thread src/AppInstallerCLIPackage/AppInstallerCLIPackage.wapproj
@Trenly Trenly marked this pull request as ready for review June 21, 2026 05:10
@Trenly Trenly requested a review from a team as a code owner June 21, 2026 05:10
Comment thread src/AppInstallerCLICore/Core.cpp Outdated
Comment thread src/AppInstallerCLICore/Core.cpp Outdated
Comment thread src/AppInstallerCLICore/Core.cpp Outdated
Comment thread src/AppInstallerCommonCore/UserSettings.cpp Outdated
Comment thread src/AppInstallerCLITests/UserSettings.cpp
Comment thread doc/windows/package-manager/winget/settings.md
Comment thread src/AppInstallerCLICore/Core.cpp Outdated
@Trenly Trenly requested review from JohnMcPMS and florelis June 29, 2026 20:52
Comment thread src/AppInstallerCommonCore/Public/winget/UserSettings.h Outdated
Comment thread src/AppInstallerCLICore/Core.cpp Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Author-Feedback Issue needs attention from issue or PR author Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Jun 30, 2026
@Trenly Trenly requested a review from florelis July 1, 2026 13:04
florelis
florelis previously approved these changes Jul 1, 2026

@florelis florelis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd want to hold off on merging until we have a plan for what to do with App Installer.

Comment thread src/AppInstallerCommonCore/UserSettings.cpp Outdated
@florelis

florelis commented Jul 1, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Trenly

Trenly commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@florelis - I get the same E2E test failures from my last checkout on master

Recording.2026-07-01.224731.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Settings Issue related to WinGet Settings Issue-Feature This is a feature request for the Windows Package Manager client. Needs-Attention Issue needs attention from Microsoft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the user to override winget's locale setting

3 participants