Skip to content

NpmDsc: Refactor Set operation#250

Open
guillermooo wants to merge 5 commits intomicrosoft:mainfrom
guillermooo:users/guillermooo/avoid-set-op-false-positives-1-0
Open

NpmDsc: Refactor Set operation#250
guillermooo wants to merge 5 commits intomicrosoft:mainfrom
guillermooo:users/guillermooo/avoid-set-op-false-positives-1-0

Conversation

@guillermooo
Copy link

@guillermooo guillermooo commented Mar 8, 2026


Microsoft Reviewers: Open in CodeFlow

The old implementation didn't account for all possible `one/two` package
names accepted by `npm install`.

We now limit user input to package names that won't yield false
positives in these cases.

NOTES:

The fix is actually restricted to `one/two` type of names; other legal
values for a package name may still yield false positives if they
reference a code repository. (Untested)
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

npmjs

These words are not needed and should be removed Jan PSobject tokio winget

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:guillermooo/winget-dsc.git repository
on the users/guillermooo/avoid-set-op-false-positives-1-0 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/22830463521/attempts/1'
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings Count
⚠️ no-newline-at-eof 1

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@guillermooo guillermooo marked this pull request as ready for review March 8, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant