Repository navigation
test: sonarqube test fixes - #4101
Merged
Claudio Castillo (claudio-codebase) merged 3 commits intoNov 3, 2026
Merged
Claudio Castillo (claudio-codebase) merged 3 commits into
Claudio Castillo (claudio-codebase) merged 3 commits into
Conversation
added 2 commits
November 2, 2026 17:24
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4101.eastus2.4.azurestaticapps.net |
Claudio Castillo (claudio-codebase)
marked this pull request as ready for review
November 3, 2026 17:43
Claudio Castillo (claudio-codebase)
requested a review
from a team
as a code owner
November 3, 2026 17:44
lehrt
approved these changes
Nov 3, 2026
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4101.eastus2.4.azurestaticapps.net |
Claudio Castillo (claudio-codebase)
deleted the
claudio-codebase/sonarqube-coverage-fixes
branch
November 3, 2026 20:00
|
Claudio Castillo (claudio-codebase)
added a commit
that referenced
this pull request
Nov 3, 2026
* fix: prevent createShareLink crash on invalid URL (#4008) * fix: handle sampleUrl parsing more robustly * suggestions for typos: https:// is incorrect or host name is incorrect. added tests and a message for first error --------- Co-authored-by: Claudio Castillo <130110208+claudio-codebase@users.noreply.github.com> Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * fix: toggle sidebar button on mobile or narrow screens added Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * fixing bug where keyboard nav did not execute opening the link from read doc button (#4087) Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * fix: reverting previous commit This reverts commit 75fc5f6. * fix: tab stop copy button and monaco editor (response header, adaptative card) (#4086) * tab stop and button ref * undoing pivot item change pretty sure there is no effect at least for this bug * forgot to pass one more buttonRef through * no effect for the user, simplifying * monaco editor is read only, fixing the tab navigation flow bug * removing async statements with no awaits to satisfy sonarqube cloudgate quality failure * added aria label changes to add to staging link and close extra PR * added aria label to message that shows up on cached set warning in SWA preview * dismiss button in warning needed aria label * adding the text to GE.json --------- Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * fix: keyboard nav returns to feedback button after closing or submitting feedback form (#4088) * added button refs to have the keyboard navigation return to the feedback when closing the form using esc, selecting x, or submitting the form * timeout unnecessary pretty sure * set keyboard focus to close button element by id instead of survey values * expecting void to pass cloud gate test * not sure how this got deleted but added back the focus behaviour. * added await to async --------- Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: keyboard nav read docs button click on read docs button using keyboard navigation * fix: persistent visual label for the key and value input boxes (#4090) * persistent visual label for the key and value input boxes. * capitalization difference * made new tests that enforce the accessible version of this interface --------- Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * fix: remove graph toolkit tab item and content (#4097) * remove graph toolkit tab item and content * remove unused imports * updated test to be consistent with changes * removed toolkit component and files --------- Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> * chore(dev): release 11.1.12 (#4094) Co-authored-by: release-please-token-provider[bot] <225477224+release-please-token-provider[bot]@users.noreply.github.com> * Pin English file transfer action to full-length commit SHA (#4100) Recreates the remaining change from #4093 on an internal branch so SonarQube can run with repository secrets. Co-authored-by: Dan Fiedler <danfiedler@microsoft.com> * test: sonarqube test fixes (#4101) * tests for uncovered code. * sonarqube fix --------- Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> --------- Co-authored-by: Diego Núñez <90226979+xDiegoNunezx@users.noreply.github.com> Co-authored-by: Claudio Castillo <clcastillo@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: release-please-token-provider[bot] <225477224+release-please-token-provider[bot]@users.noreply.github.com> Co-authored-by: Dan Fiedler <danfiedler@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Demo
Not applicable—no production UI changes.
Notes
No production code or dependency changes. Merge into dev so #4098 receives these fixes. The final quality-gate result requires a new CI/SonarCloud analysis.
Testing Instructions
After checking out this branch with dependencies installed:
Run the affected suites—passed: 75 tests across four suites:
npm test -- --runTestsByPath src\app\views\main-header\FeedbackButton.spec.tsx src\app\views\query-runner\request\feedback\FeedbackForm.spec.tsx src\app\views\sidebar\sample-queries\SampleQueries.spec.tsx src\app\views\common\copy-button\CopyButton.spec.tsx --runInBand --silentRun targeted lint—passed:
npx --no-install eslint src\app\views\main-header\FeedbackButton.spec.tsx src\app\views\query-runner\request\feedback\FeedbackForm.spec.tsx src\app\views\sidebar\sample-queries\SampleQueries.spec.tsx src\app\views\common\copy-button\CopyButton.spec.tsx --quietRun
git diff --check —passed.In CI, confirm all six lcov-N.info reports are available to SonarCloud and the new-code coverage gate passes.