RedisCommandReplicator Native method implementation#3
RedisCommandReplicator Native method implementation#3liqi19950722 wants to merge 34 commits intomicrosphere-projects:dev-prfrom
Conversation
add PrimitiveType
add ArrayType add VoidType
add ParameterizedType add ClassType
add method getMethodHandleBy add MethodHandleNotFoundException when not found
add testcontainers in the test scope add spring-boot-starter-data-redis in the test scope to autoconfigure in test
unImplement
mock unimplemented
test RedisCommandReplicatedEvent by use MethodHandleEventHandle way
jandex 3.1.6 -> 3.1.7
add writeCommandMethodHandlesCache
add judge eventHandler
|
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| @Override | ||
| public void handleEvent(Method method, Object redisCommandObject, Object... args) throws Throwable { | ||
| int length = args.length; |
There was a problem hiding this comment.
args can be null for 0-arg commands (e.g., if RedisCommandEvent.getArgs() is null), so args.length will NPE and make METHOD_HANDLE mode fail where REFLECT likely works. Consider defensively handling args == null here.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| public static MethodHandle getWriteCommandMethodHandle(Method method) { | ||
| String id = buildCommandMethodId(method); | ||
| return writeCommandMethodHandlesCache.get(id); |
There was a problem hiding this comment.
getWriteCommandMethodHandle() can return null (e.g., if initWriteCommandMethodHandleCache() logged an error and returned), which will surface later as an unhelpful NPE at the call site. Consider failing fast with a clearer exception or at least logging when the handle is missing.
🤖 Was this useful? React with 👍 or 👎
| .stream() | ||
| .filter(eventHandle -> eventHandle.name().equals(eventHandleType)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalStateException("No eventHandle found")); |
There was a problem hiding this comment.
The thrown IllegalStateException("No eventHandle found") doesn’t include CONSUMER_EVENT_HANDLE_PROPERTY_NAME or the configured eventHandleType, which can make misconfiguration harder to diagnose. Consider including those details in the exception message.
🤖 Was this useful? React with 👍 or 👎
1 participant
实现 #2
新增 dependency org.testcontainers io.smallrye.jandex
microsphere-redis-spring 主要是新增class
microsphere-redis-replicator-spring 接口有变动
RedisCommandReplicatedEventHandler Benchmark 仅供参考
