chore: fix stale nest test guidance in CLAUDE.md - #1986
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a single-line correction to CLAUDE.md's test-guidance bullet:
- Explicitly excludes
packages/bunandpackages/cloudflare(root vitest + root tsconfig) and removes nest from that pair. - States
packages/nestis excluded only from the root tsconfig, is type-checked viapnpm --filter @orpc/nest type:check, and its tests run in the root vitest.
I verified every claim against the repo: vitest.config.ts excludes only ./packages/bun/** and ./packages/cloudflare/** (so packages/nest/src/*.test.ts files are collected by root vitest); root tsconfig.json excludes packages/nest/**; packages/nest/package.json has no test script (only prepack and type:check), so the old guidance would indeed have silently run nothing. Bun/cloudflare guidance is unchanged and still accurate.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/experimental-effect
@orpc/evlog
@orpc/hibernation
@orpc/json-schema
@orpc/experimental-msw
@orpc/nest
@orpc/next
@orpc/node
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |

CLAUDE.md said
packages/nestis excluded from the root vitest and that its tests run viapnpm --filter <pkg> test. Neither is true anymore: the root vitest collects and runspackages/nest/src/*.test.ts, and@orpc/nesthas notestscript, so that command silently runs nothing. The sentence now says nest is excluded only from the root tsconfig and points to itstype:checkscript instead.Verification
vitest.config.tsexcludes onlypackages/bunandpackages/cloudflare;pnpm vitest list packages/nestshows the nest test files.tsconfig.jsonstill excludespackages/nest/**.