Skip to content

chore: fix stale nest test guidance in CLAUDE.md - #1986

Merged
dinwwwh merged 1 commit into
middleapi:mainfrom
dinwwwh:claude/agitated-wiles-4df86b
Sep 5, 2026
Merged

chore: fix stale nest test guidance in CLAUDE.md#1986
dinwwwh merged 1 commit into
middleapi:mainfrom
dinwwwh:claude/agitated-wiles-4df86b

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Sep 5, 2026

Copy link
Copy Markdown
Member

CLAUDE.md said packages/nest is excluded from the root vitest and that its tests run via pnpm --filter <pkg> test. Neither is true anymore: the root vitest collects and runs packages/nest/src/*.test.ts, and @orpc/nest has no test script, so that command silently runs nothing. The sentence now says nest is excluded only from the root tsconfig and points to its type:check script instead.

Verification

  • vitest.config.ts excludes only packages/bun and packages/cloudflare; pnpm vitest list packages/nest shows the nest test files.
  • Root tsconfig.json still excludes packages/nest/**.
  • The bun and cloudflare guidance is unchanged.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — a single-line correction to CLAUDE.md's test-guidance bullet:

  • Explicitly excludes packages/bun and packages/cloudflare (root vitest + root tsconfig) and removes nest from that pair.
  • States packages/nest is excluded only from the root tsconfig, is type-checked via pnpm --filter @orpc/nest type:check, and its tests run in the root vitest.

I verified every claim against the repo: vitest.config.ts excludes only ./packages/bun/** and ./packages/cloudflare/** (so packages/nest/src/*.test.ts files are collected by root vitest); root tsconfig.json excludes packages/nest/**; packages/nest/package.json has no test script (only prepack and type:check), so the old guidance would indeed have silently run nothing. Bun/cloudflare guidance is unchanged and still accurate.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@1986

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1986

@orpc/bun

npm i https://pkg.pr.new/@orpc/bun@1986

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1986

@orpc/cloudflare

npm i https://pkg.pr.new/@orpc/cloudflare@1986

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1986

@orpc/experimental-effect

npm i https://pkg.pr.new/@orpc/experimental-effect@1986

@orpc/evlog

npm i https://pkg.pr.new/@orpc/evlog@1986

@orpc/hibernation

npm i https://pkg.pr.new/@orpc/hibernation@1986

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1986

@orpc/experimental-msw

npm i https://pkg.pr.new/@orpc/experimental-msw@1986

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1986

@orpc/next

npm i https://pkg.pr.new/@orpc/next@1986

@orpc/node

npm i https://pkg.pr.new/@orpc/node@1986

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1986

@orpc/opentelemetry

npm i https://pkg.pr.new/@orpc/opentelemetry@1986

@orpc/pinia-colada

npm i https://pkg.pr.new/@orpc/pinia-colada@1986

@orpc/pino

npm i https://pkg.pr.new/@orpc/pino@1986

@orpc/publisher

npm i https://pkg.pr.new/@orpc/publisher@1986

@orpc/ratelimit

npm i https://pkg.pr.new/@orpc/ratelimit@1986

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1986

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1986

@orpc/swr

npm i https://pkg.pr.new/@orpc/swr@1986

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1986

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@1986

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1986

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1986

commit: 7f1353d

@codspeed-hq

codspeed-hq Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing dinwwwh:claude/agitated-wiles-4df86b (7f1353d) with main (6f5501f)

Open in CodSpeed

@dinwwwh
dinwwwh merged commit 56cf320 into middleapi:main Sep 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant