Align git identity with SSSD settings - #467
Merged
Merged
Conversation
Update the container git identity profile to derive LDAP URI, search base, username attribute, and bind credentials from the same SSSD environment used for authentication. Add a workflow smoke test covering bound and anonymous lookups, rootDSE discovery, and no-op cases, and document the first-login git config behavior for LDAP-backed users.
cmyers-mieweb
requested review from
runleveldev
and
a lite review from Copilot
September 4, 2026 19:12
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the container’s “first login” git identity setup with the same SSSD-derived LDAP configuration used for authentication, adds a CI smoke test for the profile script, and documents the behavior for admins configuring LDAP-backed environments.
Changes:
- Update
git-identity.shto derive LDAP URI, search base, username attribute, and bind behavior fromSSSD_*env vars (with rootDSE discovery fallback). - Add a workflow-executed smoke test covering bound vs anonymous lookups, rootDSE discovery, config no-op, and non-interactive no-op.
- Document the first-login git config behavior in the LDAP admin guide.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mie-opensource-landing/docs/admins/ldap-servers.md |
Documents the git identity profile behavior and its dependence on SSSD_* LDAP settings. |
images/base/test-git-identity.sh |
Adds a stub-based smoke test for LDAP mail lookup, rootDSE discovery, and no-op behavior. |
images/base/git-identity.sh |
Switches git identity LDAP lookup to use the same SSSD_* env-driven connection/bind parameters as SSSD. |
.github/workflows/build-images.yml |
Runs the new smoke test in CI prior to building images. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+37
to
41
| bind=(-x) | ||
| if [ -n "${SSSD_LDAP_DEFAULT_BIND_DN:-}" ] && [ -n "${SSSD_DEFAULT_AUTHTOK:-}" ] && | ||
| { [ -z "${SSSD_DEFAULT_AUTHTOK_TYPE:-}" ] || [ "${SSSD_DEFAULT_AUTHTOK_TYPE}" = "password" ]; }; then | ||
| bind+=(-D "$SSSD_LDAP_DEFAULT_BIND_DN" -w "$SSSD_DEFAULT_AUTHTOK") | ||
| fi |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to Issue #256
Update the container git identity profile to derive LDAP URI, search base, username attribute, and bind credentials from the same SSSD environment used for authentication. Add a workflow smoke test covering bound and anonymous lookups, rootDSE discovery, and no-op cases, and document the first-login git config behavior for LDAP-backed users.