Fix Ozwell timer clock guard for teamless events and clean clock test teardown#250
Closed
Copilot wants to merge 2 commits into
Closed
Fix Ozwell timer clock guard for teamless events and clean clock test teardown#250Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments from pull request #231
Fix Ozwell timer clock guard for teamless events and clean clock test teardown
Jun 2, 2026
Collaborator
|
cherry picked in to #231 , closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two review-thread regressions from PR #231: Ozwell incorrectly rejected ticket timer starts after user-scoped
clock_in, andbackend/tests/clock.test.tsteardown could leave fixture clock events behind.Ozwell ticket timer: accept user-scoped active clock events
start_ticket_timervalidation to allow an active clock event with noteamId(new contract) while still rejecting mismatched explicit team-scoped events.Backend clock test teardown: clean all fixture users
otherIdfixture capture.clockeventscleanup from team-based delete to fixture-user-based delete so teamless events are also removed.