feat(AudioRecorder): count-up timer and hide waveform/time when idle#248
Open
abroa01 wants to merge 1 commit into
Open
feat(AudioRecorder): count-up timer and hide waveform/time when idle#248abroa01 wants to merge 1 commit into
abroa01 wants to merge 1 commit into
Conversation
Show only elapsed time during recording (no max-duration slash) and render the waveform + time row only when not idle.
Deploying ui with
|
| Latest commit: |
130db7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58dd471d.ui-6d0.pages.dev |
| Branch Preview URL: | https://feat-audio-recorder-timer-id.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
Refines AudioRecorder’s UI to better match the recording UX used in production (beta.ozwell.ai), specifically simplifying the in-recording time display and reducing visual clutter before recording starts.
Changes:
- Update
TimeDisplayto show only the elapsed time while recording/paused (no trailing/ …segment). - Hide the waveform visualizer and time row when the recorder is in the
idlestate.
Comments suppressed due to low confidence (1)
src/components/AudioRecorder/AudioRecorder.tsx:857
- The
showMaxprop name is now misleading: whenshowMaxis true the component hides the trailing/ …portion entirely (it no longer "shows max"). Renaming this prop (and the corresponding condition) would reduce the chance of future regressions when adjusting the time display behavior.
<TimeDisplay
currentTime={currentTime}
duration={duration}
maxDuration={maxDuration}
showMax={isRecording || isPaused}
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+318
to
+322
| {!showMax && ( | ||
| <> | ||
| <span>/</span> | ||
| <span>{formatTime(duration)}</span> | ||
| </> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refines the
AudioRecordercomponent to match the productionbeta.ozwell.airecording UX.Changes
TimeDisplayshows only the elapsed time (e.g.0:07). The/ <max>portion is no longer rendered while recording, removing the implied hard cap.state !== 'idle', so the component is clean before recording starts.Notes
mieweb/ozwell-workspace(chat home page). A companion PR there bumps the submodule pointer and wires up the recorder state.Related: mieweb/ozwell-workspace#99