Add DataVis NITRO graph components.#276
Merged
Merged
Conversation
Deploying ui with
|
| Latest commit: |
3ef0495
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://623b8b5b.ui-6d0.pages.dev |
| Branch Preview URL: | https://datavis-graphs.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR adds a new DataVis NITRO graph wrapper component to the @mieweb/ui/datavis entrypoint, along with Storybook examples and the supporting build/dependency updates needed to render DataVis graph styles correctly.
Changes:
- Add
DataVisNitroGraphcomponent (wrapper around@mieweb/datavisGraphView) and export it from the DataVis NITRO barrel. - Add Storybook stories + sample dataset for graph demos.
- Update Tailwind build input and bump
@mieweb/datavisto0.0.0-PRE.4in dependencies/lockfile.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/base.css | Adds Tailwind @source so the build scans @mieweb/datavis/dist for class generation. |
| src/components/DataVisNITRO/index.ts | Exports the new DataVisNitroGraph component + props type. |
| src/components/DataVisNITRO/DataVisNitroGraph.tsx | Introduces the graph wrapper component and column/typeInfo normalization logic. |
| src/components/DataVisNITRO/DataVisNitroGraph.stories.tsx | Adds Storybook coverage for multiple chart configurations. |
| .storybook/public/sample-graph-data.json | Provides graph demo data for Storybook. |
| package.json | Bumps @mieweb/datavis devDependency to =0.0.0-PRE.4. |
| pnpm-lock.yaml | Locks the updated @mieweb/datavis version and new transitive deps. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
garrity-miepub
approved these changes
Jun 18, 2026
garrity-miepub
left a comment
garrity-miepub
left a comment
Contributor
There was a problem hiding this comment.
These graphs look awesome!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.