Fix crash if a component does not mixin Base#34
Open
khoerling wants to merge 1 commit intomikemintz:masterfrom
Open
Fix crash if a component does not mixin Base#34khoerling wants to merge 1 commit intomikemintz:masterfrom
khoerling wants to merge 1 commit intomikemintz:masterfrom
Conversation
Contributor
khoerling
commented
May 10, 2016
- facilitate 3rd-party mixins
- facilitate 3rd-party mixins
Owner
|
This seems safe to merge, but I'm curious what the scenario is in which updateComponent gets called when a component doesn't use the mixin. |
Contributor
Author
|
Good question-- it happens in util.js if QueryState is used (for subscriptions). |
Owner
|
I mean, if a component isn't using the react-rethinkdb mixin, why would updateComponent be called? |
Contributor
Author
|
Here's the line that invokes updateComponent in this case: |
Owner
|
That makes sense. But I'm also curious exactly what a React developer would have to do in order to reproduce this crash, since to me it seems like updateComponent wouldn't be called on components that don't use the mixin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.