Add fail-closed Artifact Inspector interaction contract - #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa489ccfe4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| topologyContract && | ||
| (!entryWorkUnitId || !workUnitIds.includes(entryWorkUnitId)) | ||
| ) { |
There was a problem hiding this comment.
When an Artifact Inspector candidate sets entry_work_unit_id to any declared unit other than the canonical orient unit, this check still marks the workflow ready_for_review. The unchanged sealed packet is then rejected by createUiGenerationHandoff, whose stricter validation requires orient, so callers receive a ready result they cannot advance. Compare the entry against the registry value at the workflow-review boundary.
Useful? React with 👍 / 👎.
| if ( | ||
| topologyContract && | ||
| (completionWorkUnitIds.length === 0 || | ||
| invalidCompletionIds.length > 0 || | ||
| !completionWorkUnitIds.includes("verify_result")) | ||
| ) { |
There was a problem hiding this comment.
A candidate with completion_work_unit_ids: ["verify_result"] passes this condition and is returned as ready_for_review, even though the canonical topology also requires orient and the later handoff validator requires the exact canonical set and ordering. Consequently, an unmodified reviewed packet is blocked at createUiGenerationHandoff; validate the completion IDs against the registry here rather than merely requiring one verify_result reference.
Useful? React with 👍 / 👎.
1 participant
Summary
review_required; the external primary artifact remainsexternal_not_reviewed, and this release exposes no trusted-runtime pass or attestation actionValidation
node tests/ui-generation-handoff.test.mjspassed; its 84 serial browser-backed reviews take roughly three minutes and produce no intermediate outputgit diff --checkThe single local
npm testattempt was stopped at an artificial two-minute cutoff while the slow UI-handoff group was still progressing. That group subsequently passed in isolation; hosted CI remains the authoritative full-suite gate.Deferred boundary
Genuine trusted interactive-runtime attestation is intentionally deferred to a separate project. It must supply a runnable state driver, real input and accessibility traces, focus return, occlusion, semantic re-anchoring, native-action precedence, the complete viewport/state matrix, and opaque candidate-and-contract-bound proof before Artifact Inspector can ever pass authority review.