Add portable activity-case workflow - #57
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3382027350
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const prefix = text.slice(Math.max(0, match.index - 48), match.index); | ||
| const comparator = /\b(?:under|below|less than)\s*$/.test(prefix) | ||
| ? "lt" | ||
| : /\b(?:up to|at most|no more than|maximum(?: of)?|max(?:imum)?(?: of)?)\s*$/.test(prefix) |
There was a problem hiding this comment.
When an authority grant uses a leading currency symbol, such as “may approve refunds up to $500,” the parsed prefix ends in up to $, so this regex classifies the constraint as eq instead of lte. Consequently, reviewUiWorkflowCandidate rejects a downstream “Approve refund up to $200” action as unsupported even though it is narrower than the granted limit, contrary to the downstream-narrowing contract; permit an optional leading currency symbol between the comparator and number.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
npm test— passed, including 8/8 evals and the 17-component, 65-scenario, 260-presentation browser matrix with zero raw accessibility violations and zero unresolved incomplete resultsnode scripts/sync-agent-plugin-adapters.mjs --check— passednode scripts/verify-codex-plugin.mjs— passedclaude plugin validate --strict packages/claude-plugin— passed