Skip to content

Render real surface pattern UIs - #58

Merged
mikeylong merged 2 commits into
mainfrom
codex/fix-select-indicator-slot
Sep 2, 2026
Merged

Render real surface pattern UIs#58
mikeylong merged 2 commits into
mainfrom
codex/fix-select-indicator-slot

Conversation

@mikeylong

Copy link
Copy Markdown
Owner

Summary

  • move the surface-pattern contract index ahead of the examples and link every row to its screen
  • render eight distinct fictional consumer-domain surface UIs with JudgmentKit components
  • govern the native SelectField caret with exact responsive, RTL, truncation, and forced-colors behavior
  • add a focused desktop/mobile Patterns browser gate for jump links, geometry, overflow, inert previews, console errors, and page-level Axe
  • fix the accessibility findings exposed by the rendered-page gate

Validation

  • npm test
  • npm run site:build
  • npm run benchmark
  • npm run mcp:smoke
  • staged-only review: no remaining High, Medium, or Low findings

The complete component browser run covered 17 components, 65 scenarios, 260 presentations, and 282 Axe scans with zero violations and zero unresolved incomplete findings. The focused Patterns gate covered eight links and eight distinct surfaces at 1280px and 390px with zero page overflow and zero Axe violations.

Verification boundary

The generic visual-composition adapter does not yet model a native select whose design-system indicator is a sibling inside the field wrapper. This change therefore uses the component-specific browser contract as the exact authority for that composition; it does not widen the generic verifier runtime.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
judgmentkit-ai Ready Ready Preview Sep 2, 2026 7:02am UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T06:41:43.505878Z 126beeb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 126beebafb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/build-site.mjs
Comment thread src/react/native-components.mjs Outdated
@mikeylong
mikeylong merged commit 765e127 into main Sep 2, 2026
5 checks passed
@mikeylong
mikeylong deleted the codex/fix-select-indicator-slot branch September 2, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant