Repository navigation
feat: harden proxy against framing desync and idle clients - #8
Merged
Merged
Conversation
Reject commands whose terminator does not match their z/n prefix and unprefixed INSTREAM, since clamd frames those differently from the proxy and raw stream data could reach it as commands. Close the session after a blocked command, add --idle-timeout and --max-connections, always close the backend when the client side ends, and flush backend responses to the client as they arrive.
miklosn
force-pushed
the
feat/hardening
branch
from
November 4, 2026 11:42
d117744 to
36dfd91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zINSTREAM\nput the proxy in raw-forward mode while clamd was not in stream mode); reject unprefixed INSTREAM--idle-timeout(default 120s): drop client connections with no traffic--max-connections(default unlimited): cap concurrent clientsFirst commit is the failing reproduction test; the fix follows.
This change is