Skip to content

refactor: extends from BaseEntity to inherit the id property #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronPerezPerez wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: extends from BaseEntity to inherit the id property #83

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3187802
refactor: extends from BaseEntity to inherit the id property
AaronPerezPerez Aug 15, 2024
df32803
Apply suggestions from code review
B4nan Jan 29, 2025
1ade4e8
fix tests
B4nan Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/entities/Publisher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { Collection, Entity, Enum, OneToMany, Opt, PrimaryKey, Property } from '@mikro-orm/core';
import { Book } from './Book';
import { BaseEntity } from './BaseEntity';

@Entity()
export class Publisher {

@PrimaryKey()
id!: number;
export class Publisher extends BaseEntity {
Comment thread
B4nan marked this conversation as resolved.

@Property()
name: string;
Expand All @@ -17,6 +15,7 @@ export class Publisher {
type: PublisherType & Opt;

constructor(name: string, type = PublisherType.LOCAL) {
super();
this.name = name;
this.type = type;
}
Expand Down