EVM: Add cross chain swap operation#67
Open
PedroAraoz wants to merge 6 commits intoevm/refactor-intents-with-operationsfrom
Open
EVM: Add cross chain swap operation#67PedroAraoz wants to merge 6 commits intoevm/refactor-intents-with-operationsfrom
PedroAraoz wants to merge 6 commits intoevm/refactor-intents-with-operationsfrom
Conversation
alavarello
reviewed
Mar 17, 2026
alavarello
approved these changes
Mar 18, 2026
| function execute(Operation memory, bytes32, bytes memory) external override { | ||
| Intent memory intent; | ||
| Proposal memory proposal; | ||
| function execute(Intent memory intent, Proposal memory proposal, uint256) external override { |
Member
There was a problem hiding this comment.
I know it's just a mock but lets add the parameter name
Suggested change
| function execute(Intent memory intent, Proposal memory proposal, uint256) external override { | |
| function execute(Intent memory intent, Proposal memory proposal, uint256 index) external override { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.