MOBILEWEBVIEW-75: fix back button for modal window#686
Merged
sergeysozinov merged 1 commit intomission/webview-inappfrom Mar 5, 2026
Merged
MOBILEWEBVIEW-75: fix back button for modal window#686sergeysozinov merged 1 commit intomission/webview-inappfrom
sergeysozinov merged 1 commit intomission/webview-inappfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates in-app back button handling to properly dismiss modal windows by switching from view-level key interception to OnBackPressedDispatcher callbacks.
Changes:
- Removed legacy back-button interception (
BackButtonLayout/BackButtonHandler) fromInAppConstraintLayout. - Added
OnBackPressedCallbackregistration/cleanup to dismiss modal in-apps on system back. - Removed obsolete dismiss-listener binding from
WebViewInAppViewHolder(now a no-opbind()).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/WebViewInappViewHolder.kt | Drops old dismiss-listener binding; bind() becomes empty. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/ModalWindowInAppViewHolder.kt | Registers an OnBackPressedCallback on show and removes it on hide to dismiss modal on back press. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/InAppConstraintLayout.kt | Removes key-event based back handling previously used for dismissal. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/BackButtonLayout.kt | Deleted (no longer used). |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/BackButtonHandler.kt | Deleted (no longer used). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/ModalWindowInAppViewHolder.kt
Show resolved
Hide resolved
enotniy
reviewed
Mar 5, 2026
...src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/ModalWindowInAppViewHolder.kt
Show resolved
Hide resolved
enotniy
approved these changes
Mar 5, 2026
...src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/view/ModalWindowInAppViewHolder.kt
Show resolved
Hide resolved
enotniy
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILEWEBVIEW-75