MOBILEWEBVIEW-34: Refactoring close inapp#687
Open
enotniy wants to merge 1 commit intomission/webview-inappfrom
Open
MOBILEWEBVIEW-34: Refactoring close inapp#687enotniy wants to merge 1 commit intomission/webview-inappfrom
enotniy wants to merge 1 commit intomission/webview-inappfrom
Conversation
| val view: WebViewPlatformView = controller.view | ||
| inAppLayout.removeView(view) | ||
| view.parent.safeAs<ViewGroup>()?.removeView(view) | ||
| controller.destroy() |
Collaborator
There was a problem hiding this comment.
тут destroy вызывается и ещё ниже следом
webViewController?.destroy()
| mindboxLogI("In-app dismissed by webview action ${message.action} with payload ${message.payload}") | ||
| hide() | ||
| release() | ||
| inAppController.close() |
Collaborator
There was a problem hiding this comment.
Здесь и в других аналогичных местах с onInAppDismiss проблема будет:
Вызывается closeCurrentInapp , а там внутри
if (isInAppActive()) {
currentHolder?.wrapper?.inAppActionCallbacks
?.copy(onInAppDismiss = { mindboxLogI("Do not save the closing timestamp for in-app as it's restored automatically when the session is reopened") })
?.onInAppDismiss
?.onDismiss()
}
флаг isInAppActive мы нигде не сбрасываем в false.
Поэтому дисмисс внутри closeCurrentInApp так же выполнитится
| controller.executeOnViewThread { | ||
| hide() | ||
| release() | ||
| inAppController.close() |
Collaborator
There was a problem hiding this comment.
Не понимаю почему, но потестил и заметил , что при разворачивании приложения, где WebView каждый раз отправляется Inapp.Show и счетчики показа увеличиваются. Видимо из-за того что pausedHolder затираем
15:14:04.067 I InAppMessageManagerImpl: Render time is 373602ms, prepared time is 452ms
15:14:04.067 I InAppRepositoryImpl: Increase count of shown inapp per session, previous count 7
15:14:04.071 I InAppRepositoryImpl: Increase count of shown inapp per day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILEWEBVIEW-34