Change initialDelaySec and delaySec types to int #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in strict types, the `sleep($asyncOptions->delaySec);` in Client and ClientV2 result in deprication error being raised. I've converted the fields to int (setters already expect int) and set delaySec to 1 because it already was converted to that https://3v4l.org/F9Ir7
Updated minimum delay constants to use integer values.
Collaborator
|
Hello, thank you for opening this. The matter is not with the parameter typing, but rather the way we're handling delays altogether. Feel free to add anything there that you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running in strict types, the
sleep($asyncOptions->delaySec);in Client and ClientV2 result in deprication error being raised. I've converted the fields to int (setters already expect int) and set delaySec to 1 because it already was converted to that https://3v4l.org/F9Ir7Types of changes