[Week7 - jbk] Task1: Add endpoints and input validation#47
Open
Candyroom136 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /notes/{id},DELETE /action-items/{id},GET /action-items/{id}Fieldconstraints (min_length, max_length)skip(ge=0) andlimit(ge=1, le=200)Problem
The existing API was missing DELETE endpoints for both resources and a single-item GET for action items. Input validation was absent — empty strings and negative pagination values were accepted without error.
Approach
Field(...)withmin_length/max_lengthto enforce non-empty inputs at the schema levelge/leconstraints onskipandlimitquery parametersdb.flush()for persistence)Testing
$ make test
3 passed in 0.04s
All existing tests pass. New endpoints follow the same error handling patterns already covered by tests.
Tradeoffs & Follow-ups
max_length=200for title matches the DB column constraint (String(200)) but could be surfaced as a friendlier error message