[Week7 - pky] Task1: Add DELETE endpoints and input validation#53
Open
kunyoungp wants to merge 1 commit into
Open
[Week7 - pky] Task1: Add DELETE endpoints and input validation#53kunyoungp wants to merge 1 commit into
kunyoungp wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /notes/{note_id}endpoint (204 No Content, 404 if missing)GET /action-items/{item_id}andDELETE /action-items/{item_id}endpointsFieldconstraints for input validation:NoteCreate: title (1-200 chars), content (1-10,000 chars)ActionItemCreate: description (1-2,000 chars)NotePatch/ActionItemPatch: same constraints on optional fieldsTest plan
test_delete_note— delete returns 204, subsequent GET returns 404test_delete_note_not_found— delete non-existent note returns 404test_note_validation_empty_title— empty title returns 422test_note_validation_title_too_long— title >200 chars returns 422test_get_action_item_by_id— GET returns 200 with correct datatest_get_action_item_not_found— GET non-existent returns 404test_delete_action_item— delete returns 204test_delete_action_item_not_found— delete non-existent returns 404test_action_item_validation_empty_description— empty description returns 422make test)Notable tradeoffs
Field()for declarative validation rather than custom validatorsNotePatchoptional fields useField(None, min_length=1, ...)so validation only triggers when a value is provided🤖 Generated with Claude Code