[Week7 - hjy] Task1: Add endpoints and input validation#57
Open
HyungjoonYang wants to merge 1 commit into
Open
[Week7 - hjy] Task1: Add endpoints and input validation#57HyungjoonYang wants to merge 1 commit into
HyungjoonYang wants to merge 1 commit into
Conversation
Add DELETE for notes/action-items, GET for single action item. Add Pydantic field validation (blank strings, title length) and query param constraints (skip >= 0, limit 1-200, invalid sort → 400). 24 new tests covering all new endpoints and validation cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /notes/{note_id}endpoint (204 No Content, 404 if missing)GET /action-items/{item_id}andDELETE /action-items/{item_id}endpointsFieldconstraints for input validation:NoteCreate: title (1-200 chars, non-blank), content (non-blank)ActionItemCreate: description (non-blank)NotePatch/ActionItemPatch: same constraints on optional fieldsskip >= 0,1 <= limit <= 200Test plan
Notable tradeoffs
field_validatoron top ofmin_lengthfor stricter checking🤖 Generated with Claude Code