Repository navigation
chore(ci): delete the jobs that run on the self-hosted runners (ENG-2000) - #4
Open
lucas-koontz wants to merge 2 commits into
Open
lucas-koontz wants to merge 2 commits into
lucas-koontz wants to merge 2 commits into
Conversation
…000) This change deletes every job that asks for mdb-dev or mdb-prod, along with four workflows built around those jobs. Every remaining job runs on a GitHub-hosted runner, which GitHub recommends for public repositories. Pull requests, forks included, still run the unit tests. The four deleted workflows: - deploy.yml and tests_integration.yml ran only on mdb-dev or mdb-prod. - build_deploy_staging.yml built and pushed the Docker images after each merge, then deployed and tested through those two files. Its one hosted job ran the unit tests after the merge. - build_deploy_prod.yml was the release pipeline. On a published release it pushed the mindsdb package to PyPI and Docker Hub, then deployed it. Its one hosted job ran the unit tests ahead of those steps. This repository has no published releases. build_deploy_dev.yml keeps the changed-files filter, the unit tests and All Tests Succeeded. Its workflow is renamed "Test pull request", because it no longer builds or deploys anything. - A pull request that changes only files under docs/ or assets/, or only Markdown files, still skips the unit tests. Every other change runs them. - A version bump in mindsdb/__about__.py now runs the unit tests, because setup.py builds the package from that file. Until now, the deleted post-merge run was the only test a version bump got. - An edit to build_deploy_dev.yml alone now runs the unit tests too. The filter also drops an exclusion for test_on_deploy.yml, a file that does not exist. - All Tests Succeeded fails when the filter job fails or is cancelled. It also fails when the filter sends a change to the unit tests and they do not pass. - The write permissions move from the whole workflow onto the unit-test call, because tests_unit.yml asks for them. The filter and the final check get read access only. - dorny/paths-filter is pinned to the v3.0.4 commit that v3 points to. - The unit-test call stops inheriting secrets, because tests_unit.yml reads none. scripts/run_integration_tests.sh no longer points at the deleted tests_integration.yml. Part of "Take the public repos off the credentialed runner group and require devops to release a privileged run", owned by Lucas Koontz. Refs: ENG-2000
This was referenced Oct 4, 2026
Draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As a maintainer of this public repository
I want CI to test every pull request on GitHub-hosted runners, and nothing to build, deploy or publish on a merge or a release
So that every pull request, forks included, gets the same checks, and a merge no longer ends in a red run
Why this matters
Each of the last two merges into
mainended in a redBuild and deploy to stagingrun: it built and pushed Docker images, then its deploy jobs failed before running a step (run 34555291819). This PR deletes that pipeline and the release pipeline, and keeps the unit tests on every pull request, on GitHub-hosted runners, as GitHub recommends for public repositories. A version bump now runs those tests before it merges, where until now only the deleted post-merge run tested it.Test plan
main, forks included, runsRun Unit Testsunless it changes only Markdown or files underdocs/orassets/, and a version bump alone runs them,Check pip installationincluded.All Tests Succeededfails when the file filter fails or the tests it sends a change to fail.tests_unit.yml,matrix_includes.jsonand the other remaining workflows are unchanged.mainis merged into this branch, so its unit tests run onmain's current dependencies.Part of ENG-2000. This PR depends on no other change.